Treat focusable as enumerated boolean SVG attribute#13339
Merged
gaearon merged 2 commits intofacebook:masterfrom Aug 7, 2018
Merged
Treat focusable as enumerated boolean SVG attribute#13339gaearon merged 2 commits intofacebook:masterfrom
gaearon merged 2 commits intofacebook:masterfrom
Conversation
gaearon
changed the title
nhunzaker
approved these changes
Aug 7, 2018
Contributor
nhunzaker
left a comment
nhunzaker
left a comment
There was a problem hiding this comment.
Does the attribute table need to be updated?
Contributor
|
What does this change do to the attribute table? Particularly, we should confirm that any change came with a warning before this change. |
Collaborator
Author
|
Yep. Pushed. |
Merged
This was referenced Sep 7, 2018
ghost
mentioned this pull request
This was referenced Nov 1, 2018
This was referenced Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12481.
It's a small behavior change but the old behavior both had a warning (in which case we don't provide strong guarantees) and was inconsistent with other similar attributes. The old behavior was also unintuitive.
Particularly, this relaxes the restriction on
<svg focusable>to accept booleans. It's an enumerated attribute with'true','false', and'auto'values. This makes it consistent with how we already handle the HTMLdraggableattribute (which also has'true','false', and'auto'values).Before:
After:
There's no behavior change for cases that didn't warn.
I couldn't find other attributes like this except
syncMaster(which seems very niche?) so I'm not worried about this list growing.