Ignore noscript content on the client

[Ephem]

Fixes #11423

First PR, CLA is signed.

Before this PR <noscript><img src="..." /></noscript> would:

• Warn about a server/client mismatch
• Download the img
• (Run any lifecycles for components inside the noscript)

I tried fixing this by only touching ReactDOM and found that by treating <noscript> as an element that only supports text it achieved the desired effects. This also keeps the markup in the DOM on the client which is desirable as per the issue.

Questions:

• Is this a hacky way to do it? In a sense shouldSetTextContent is true for noscript-elements on the client, but could it have any unintended side-effects now or in the future?
• Solving it this way means that the content inside a noscript could still be updated on the client as long as children is a string, is the desirable or confusing?
• Is the test a sane and robust way to test for this?

[pull-bot]

Details of bundled changes.

Comparing: 28b9289...eb7d792

react-scheduler

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react-scheduler.development.js	+24.4%	+23.6%	15.4 KB	19.17 KB	4.65 KB	5.74 KB	UMD_DEV
react-scheduler.production.min.js	🔺+15.8%	🔺+21.0%	2.73 KB	3.16 KB	1.26 KB	1.53 KB	UMD_PROD

Generated by 🚫 dangerJS

[gaearon]

Ideally you might want to try writing an extra test in ReactDOMServerIntegration*-test suite which runs a variety of scenarios for each test.

[Ephem]

Thank you for the quick feedback, I'll have a look at that test suite and see where I can add some more tests.

First ci-fail was a bad test that for some reason worked locally, fixed now. Not sure about the current results.json fail though.

[Ephem]

Added another test. Seeing how tests in ServerIntegration seem to only test output I followed that pattern.

The existing test also tests that render on components inside of <noscript> only gets called on the server, this is kind of a heuristic for if any sideeffects of the component are triggered. One could also test the same for the constructor or any/all of the lifecycles but I'm not sure if that would be helpful?

[gaearon]

I think this makes sense to me. Thanks.