Delete Suspense Fixture#15273
Merged
Merged
Conversation
As far as I can tell this build is broken. Let's fix or delete. If I can't test, I can't patch it up when I break it.
gaearon
approved these changes
Mar 30, 2019
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
I just started working on a different, more comprehensive one today. That one’s also broken, but for a valid reason — lacking primitives. So I can re-add later after solutions are in place. And it will serve as base for relevant recipes. But this one can go.
|
@gaearon reminder to add that back in. the 16.x roadmap points to the now-removed directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell this build is broken. I get a build error claiming invalid syntax (for Flow features). Let's fix or delete. If I can't test, I can't patch it up when I break it.