Update ReactUpdates-test by rickhanlonii · Pull Request #28061 · react/react

rickhanlonii · 2024-01-23T21:17:46Z

Overview

These tests are important for ReactDOM.render, so instead of just re-writing them to createRoot and losing coverage:

Moved the .render tests to ReactLegacyUpdates
Re-wrote the tests in ReactUpdates to use createRoot
Remove unstable_batchedUpdates from ReactUpdates

In a future PR, when I flag batchedUpdates with a Noop, I can add the gate to just the tests in ReactLegacyUpdates.

react-sizebot · 2024-01-23T21:22:06Z

Comparing: b2d6371...d6fc098

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.24 kB	176.24 kB	=	54.88 kB	54.88 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.34 kB	178.34 kB	=	55.53 kB	55.53 kB
facebook-www/ReactDOM-prod.classic.js	=	571.94 kB	571.94 kB	=	100.56 kB	100.56 kB
facebook-www/ReactDOM-prod.modern.js	=	555.70 kB	555.70 kB	=	97.62 kB	97.62 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against d6fc098

rickhanlonii · 2024-01-23T21:19:04Z

-      componentDidUpdate() {
-        updateCount++;
-      }
+  it('should batch state when updating state twice', async () => {


While I was here, I rewote any of the class component tests that don't rely on class component features (like setState callbacks) to function components.

rickhanlonii · 2024-01-23T21:19:37Z

-        updateCount++;
-      }
+      React.useLayoutEffect(() => {
+        Scheduler.log('Commit');


I also ported any tests tracking logs/ops to use the newer Scheduler.log test helpers to modernize them.

rickhanlonii · 2024-01-23T21:22:12Z

      child.forceUpdate();
    });
+
+    expect.assertions(6);


Added this, since there's wasn't anything confirming that the expects were actually running.

rickhanlonii · 2024-01-23T21:22:52Z

-    ReactDOM.render(<App />, document.createElement('div'));
-  });
-
-  it('unstable_batchedUpdates should return value from a callback', () => {


Deleted, since this is only testing unstable_batchedUpdates. The test exists in ReactLegacyUpdates now.

rickhanlonii · 2024-01-23T21:23:52Z

-    expect(result).toEqual(42);
-  });

-  it('unmounts and remounts a root in the same batch', () => {


Deleted, because createRoot does not support rendering to an unmounted root. The .render version exists in ReactLegacyUpdates now, and we have a test for the error rendering to an unmounted container elsewhere.

rickhanlonii · 2024-01-23T21:25:30Z

+    });
    expect(container.textContent).toBe('goodbye');
    expect(mounts).toBe(1);
+    expect(onChangeCalled).toBeTruthy();


Added this because I was worried the change handler wasn't being called, which I think would still pass the above assertions.

rickhanlonii · 2024-01-23T21:26:08Z

+    expect(onChangeCalled).toBeTruthy();
  });

-  it('mounts and unmounts are sync even in a batch', () => {


Renamed this, since in the new root they are batched.

rickhanlonii · 2024-01-23T21:26:33Z

-    expect(ops).toEqual(['Hello', '']);
-  });
-
-  it(


Deleted all these legacy mode tests, they're in ReactLegacyUpdates.

rickhanlonii · 2024-01-23T21:27:46Z

      });
    });
+
+    expect(subscribers.length).toBe(limit);


Added this because there was nothing confirming things actually rendered.

noahlemen

nice!

jackpope

Walked through changes with Rick. Some additional opportunities to switch to scheduler log but overall looks good

- react/react#28250 - react/react#28225 - react/react#28123 - react/react#28240 - react/react#28239 - react/react#28245 - react/react#28244 - react/react#28238 - react/react#28235 - react/react#28221 - react/react#28215 - react/react#28214 - react/react#28213 - react/react#28212 - react/react#28211 - react/react#28247 - react/react#28210 - react/react#28186 - react/react#28232 - react/react#28169 - react/react#28177 - react/react#28170 - react/react#28168 - react/react#28122 - react/react#27982 - react/react#28217 - react/react#28223 - react/react#28208 - react/react#28209 - react/react#28200 - react/react#28199 - react/react#28198 - react/react#28197 - react/react#28196 - react/react#28194 - react/react#28192 - react/react#28191 - react/react#28182 - react/react#28181 - react/react#28180 - react/react#28178 - react/react#28201 - react/react#28176 - react/react#28162 - react/react#28131 - react/react#28190 - react/react#28172 - react/react#28171 - react/react#28173 - react/react#28174 - react/react#28175 - react/react#28136 - react/react#28135 - react/react#28134 - react/react#28133 - react/react#28132 - react/react#28130 - react/react#28202 - react/react#28102 - react/react#28161 - react/react#28193 - react/react#28195 - react/react#28189 - react/react#28160 - react/react#28096 - react/react#28183 - react/react#28125 - react/react#28157 - react/react#28115 - react/react#28124 - react/react#28163 - react/react#28164 - react/react#28150 - react/react#28159 - react/react#28069 - react/react#28110 - react/react#28148 - react/react#28116 - react/react#28099 - react/react#28100 - react/react#28147 - react/react#28128 - react/react#28126 - react/react#28139 - react/react#28140 - react/react#28141 - react/react#28142 - react/react#28113 - react/react#28129 - react/react#28114 - react/react#28053 - react/react#28091 - react/react#28087 - react/react#28112 - react/react#28086 - react/react#28101 - react/react#28106 - react/react#28117 - react/react#28118 - react/react#28105 - react/react#27883 - react/react#28111 - react/react#28095 - react/react#28108 - react/react#28090 - react/react#28089 - react/react#28076 - react/react#28074 - react/react#28103 - react/react#28098 - react/react#28097 - react/react#28068 - react/react#28093 - react/react#28094 - react/react#28073 - react/react#28084 - react/react#28063 - react/react#28085 - react/react#28083 - react/react#28065 - react/react#28061 - react/react#28077 - react/react#28075 - react/react#28078 - react/react#28050 - react/react#28011 - react/react#28055 - react/react#28066 - react/react#28067 - react/react#28010 - react/react#27993 - react/react#28052 - react/react#28060 - react/react#28059 - react/react#28034 - react/react#28033 - react/react#28004 - react/react#28051 - react/react#28012 - react/react#28001 - react/react#28002 - react/react#27995 - react/react#28006 - react/react#28005 - react/react#28007 - react/react#28008 - react/react#28009 - react/react#28000 - react/react#28003 - react/react#27997 - react/react#27240 - react/react#27977 - react/react#27940 - react/react#27939 - react/react#28090 - react/react#28089 - react/react#28076 - react/react#28074 - react/react#28103 - react/react#28098 - react/react#28097 - react/react#28068 - react/react#28093 - react/react#28094 - react/react#28073 - react/react#28084 - react/react#28063 - react/react#28085 - react/react#28083 - react/react#28065 - react/react#28061 - react/react#28077 - react/react#28075 - react/react#28078 - react/react#28050 - react/react#28011 - react/react#28055 - react/react#28066 - react/react#28067 - react/react#28010 - react/react#27993 - react/react#28052 - react/react#28060 - react/react#28059 - react/react#28034 - react/react#28033 - react/react#28004 - react/react#28051 - react/react#28012 - react/react#28001 - react/react#28002 - react/react#27995 - react/react#28006 - react/react#28005 - react/react#28007 - react/react#28008 - react/react#28009 - react/react#28000 - react/react#28003 - react/react#27997 - react/react#27240 - react/react#27977 - react/react#27940 - react/react#27939

Updates React from 60a927d04 to 2bc7d336a Also updates aliases for `react.shared-subset` to `react.react-server` ### React upstream changes - react/react#28250 - react/react#28225 - react/react#28123 - react/react#28240 - react/react#28239 - react/react#28245 - react/react#28244 - react/react#28238 - react/react#28235 - react/react#28221 - react/react#28215 - react/react#28214 - react/react#28213 - react/react#28212 - react/react#28211 - react/react#28247 - react/react#28210 - react/react#28186 - react/react#28232 - react/react#28169 - react/react#28177 - react/react#28170 - react/react#28168 - react/react#28122 - react/react#27982 - react/react#28217 - react/react#28223 - react/react#28208 - react/react#28209 - react/react#28200 - react/react#28199 - react/react#28198 - react/react#28197 - react/react#28196 - react/react#28194 - react/react#28192 - react/react#28191 - react/react#28182 - react/react#28181 - react/react#28180 - react/react#28178 - react/react#28201 - react/react#28176 - react/react#28162 - react/react#28131 - react/react#28190 - react/react#28172 - react/react#28171 - react/react#28173 - react/react#28174 - react/react#28175 - react/react#28136 - react/react#28135 - react/react#28134 - react/react#28133 - react/react#28132 - react/react#28130 - react/react#28202 - react/react#28102 - react/react#28161 - react/react#28193 - react/react#28195 - react/react#28189 - react/react#28160 - react/react#28096 - react/react#28183 - react/react#28125 - react/react#28157 - react/react#28115 - react/react#28124 - react/react#28163 - react/react#28164 - react/react#28150 - react/react#28159 - react/react#28069 - react/react#28110 - react/react#28148 - react/react#28116 - react/react#28099 - react/react#28100 - react/react#28147 - react/react#28128 - react/react#28126 - react/react#28139 - react/react#28140 - react/react#28141 - react/react#28142 - react/react#28113 - react/react#28129 - react/react#28114 - react/react#28053 - react/react#28091 - react/react#28087 - react/react#28112 - react/react#28086 - react/react#28101 - react/react#28106 - react/react#28117 - react/react#28118 - react/react#28105 - react/react#27883 - react/react#28111 - react/react#28095 - react/react#28108 - react/react#28090 - react/react#28089 - react/react#28076 - react/react#28074 - react/react#28103 - react/react#28098 - react/react#28097 - react/react#28068 - react/react#28093 - react/react#28094 - react/react#28073 - react/react#28084 - react/react#28063 - react/react#28085 - react/react#28083 - react/react#28065 - react/react#28061 - react/react#28077 - react/react#28075 - react/react#28078 - react/react#28050 - react/react#28011 - react/react#28055 - react/react#28066 - react/react#28067 - react/react#28010 - react/react#27993 - react/react#28052 - react/react#28060 - react/react#28059 - react/react#28034 - react/react#28033 - react/react#28004 - react/react#28051 - react/react#28012 - react/react#28001 - react/react#28002 - react/react#27995 - react/react#28006 - react/react#28005 - react/react#28007 - react/react#28008 - react/react#28009 - react/react#28000 - react/react#28003 - react/react#27997 - react/react#27240 - react/react#27977 - react/react#27940 - react/react#27939 - react/react#28090 - react/react#28089 - react/react#28076 - react/react#28074 - react/react#28103 - react/react#28098 - react/react#28097 - react/react#28068 - react/react#28093 - react/react#28094 - react/react#28073 - react/react#28084 - react/react#28063 - react/react#28085 - react/react#28083 - react/react#28065 - react/react#28061 - react/react#28077 - react/react#28075 - react/react#28078 - react/react#28050 - react/react#28011 - react/react#28055 - react/react#28066 - react/react#28067 - react/react#28010 - react/react#27993 - react/react#28052 - react/react#28060 - react/react#28059 - react/react#28034 - react/react#28033 - react/react#28004 - react/react#28051 - react/react#28012 - react/react#28001 - react/react#28002 - react/react#27995 - react/react#28006 - react/react#28005 - react/react#28007 - react/react#28008 - react/react#28009 - react/react#28000 - react/react#28003 - react/react#27997 - react/react#27240 - react/react#27977 - react/react#27940 - react/react#27939 Closes NEXT-2331

## Overview These tests are important for `ReactDOM.render`, so instead of just re-writing them to `createRoot` and losing coverage: - Moved the `.render` tests to `ReactLegacyUpdates` - Re-wrote the tests in `ReactUpdates` to use `createRoot` - Remove `unstable_batchedUpdates` from `ReactUpdates` In a future PR, when I flag `batchedUpdates` with a Noop, I can add the gate to just the tests in `ReactLegacyUpdates`.

## Overview These tests are important for `ReactDOM.render`, so instead of just re-writing them to `createRoot` and losing coverage: - Moved the `.render` tests to `ReactLegacyUpdates` - Re-wrote the tests in `ReactUpdates` to use `createRoot` - Remove `unstable_batchedUpdates` from `ReactUpdates` In a future PR, when I flag `batchedUpdates` with a Noop, I can add the gate to just the tests in `ReactLegacyUpdates`. DiffTrain build for commit 8bb6ee1.

Update ReactUpdates-test

9059159

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 23, 2024

Merge branch 'main' into rh/react-updates-tests

4329f70

Fix lint

47ccb56

rickhanlonii marked this pull request as ready for review January 23, 2024 21:30

rickhanlonii commented Jan 23, 2024

View reviewed changes

noahlemen approved these changes Jan 24, 2024

View reviewed changes

jackpope approved these changes Jan 24, 2024

View reviewed changes

More Scheduler.log

d6fc098

rickhanlonii merged commit 8bb6ee1 into react:main Jan 25, 2024

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update ReactUpdates-test#28061

Update ReactUpdates-test#28061
rickhanlonii merged 4 commits into
react:mainfrom
rickhanlonii:rh/react-updates-tests

rickhanlonii commented Jan 23, 2024

Uh oh!

react-sizebot commented Jan 23, 2024 •

edited

Loading

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

rickhanlonii Jan 23, 2024

Uh oh!

noahlemen left a comment

Uh oh!

jackpope left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rickhanlonii commented Jan 23, 2024

Overview

Uh oh!

react-sizebot commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noahlemen left a comment

Choose a reason for hiding this comment

Uh oh!

jackpope left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

react-sizebot commented Jan 23, 2024 •

edited

Loading