[cleanup] remove flag enableAddPropertiesFastPath#31062
Merged
Conversation
The experiment was tested internally and rolled out, replacing the flag with `true`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: f9ebd85a196948be17efdd6774b4d0464b3b1f53...403bab0dc81e95875816479c1ae42cb777fe83be Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
yungsters
approved these changes
Oct 2, 2024
Contributor
yungsters
left a comment
yungsters
left a comment
There was a problem hiding this comment.
Hmm... @dmytrorykun, can we also change addNestedProperty to use fastAddProperties (and then delete addProperties and rename fastAddProperties to addProperties)?
dmytrorykun
approved these changes
Oct 7, 2024
Contributor
Author
|
Landing as we should run a different experiment if we also change the update path. |
This was referenced Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experiment was tested internally and rolled out, replacing the flag with
true.