Skip to content

Fix repr issue with show_doc#588

Merged
jph00 merged 2 commits into
AnswerDotAI:masterfrom
muellerzr:repr
Feb 21, 2022
Merged

Fix repr issue with show_doc#588
jph00 merged 2 commits into
AnswerDotAI:masterfrom
muellerzr:repr

Conversation

@muellerzr

Copy link
Copy Markdown
Contributor

Solves #587 by having type_repr use _format_annos rather than get_name

image

The other option to consider is just completely change how get_name works and have it be _format_annos.inner

cc @jph00

(Also mark this as Enhancement)

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00

jph00 commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Great!

@jph00 jph00 merged commit aa1ae65 into AnswerDotAI:master Feb 21, 2022
@jph00 jph00 added the bug Something isn't working label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants