Skip to content

Default dump format should be changed for Python SDK #133

@woop

Description

@woop

Expected Behavior

When using the Python SDK to dump an "Importer" to a YAML file, the type should be "file.csv"

Current Behavior

Using the dump method results in the importer's type being saved as "file", which fails validation when using the YAML file for importing from the CLI.

Steps to reproduce

Follow the current Quickstart here

Dump the importer after it is defined.

importer.dump('out.yaml')

Specifications

  • Version: 0.0.1
  • Platform: Ubuntu 18.04
  • Subsystem:

Possible Solution

This default probably needs to be changed:
https://github.com/gojek/feast/blob/master/sdk/python/feast/sdk/importer.py#L121

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions