Python SDK enhancements#264
Merged
Merged
Conversation
Member
woop
commented
Oct 22, 2019
woop
commented
- Refactor CLI
- Support additional types with tests
- Improve YAML loading
- Improve List type performance
- Fix bug with source handling
- Improve exception handling
* Refactor CLI * Support additional types with tests * Improve YAML loading * Improve List type performance * Fix bug with source handling * Improve exception handling
woop
requested review from
davidheryanto,
pradithya,
thirteen37,
tims and
zhilingc
as code owners
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thirteen37
reviewed
Oct 22, 2019
woop
commented
Oct 22, 2019
Co-Authored-By: Yu-Xi Lim <thirteen37@users.noreply.github.com>
Collaborator
|
@woop: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.