From 2fffaefd01b3c4d6413ff36868c9cb4889223fc1 Mon Sep 17 00:00:00 2001 From: zhilingc Date: Wed, 20 Nov 2019 15:49:54 +0800 Subject: [PATCH 1/2] Change default job metrics sink to statsd --- core/src/main/resources/application.yml | 12 +++++------- infra/charts/feast/charts/feast-core/values.yaml | 4 ++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/core/src/main/resources/application.yml b/core/src/main/resources/application.yml index be4f8c6b72a..6af41db4fbd 100644 --- a/core/src/main/resources/application.yml +++ b/core/src/main/resources/application.yml @@ -33,14 +33,12 @@ feast: metrics: # Enable metrics pushing for all ingestion jobs. enabled: false - # Type of metrics sink. Only prometheus is currently supported. - type: prometheus - # Host of the metrics sink. In the case of prometheus, this is the host of the prometheus - # pushGateway to sink metrics to. + # Type of metrics sink. Only statsd is currently supported. + type: statsd + # Host of the metrics sink. host: localhost - # Port of the metrics sink. In the case of prometheus, this is the port of the prometheus - # pushGateway to sink metrics to. - port: 9091 + # Port of the metrics sink. + port: 8125 stream: # Feature stream type. Only kafka is supported. diff --git a/infra/charts/feast/charts/feast-core/values.yaml b/infra/charts/feast/charts/feast-core/values.yaml index 5fddd4daaa3..87a510737eb 100644 --- a/infra/charts/feast/charts/feast-core/values.yaml +++ b/infra/charts/feast/charts/feast-core/values.yaml @@ -64,9 +64,9 @@ application.yaml: options: {} metrics: enabled: false - type: prometheus + type: statsd host: localhost - port: 9091 + port: 8125 stream: type: kafka options: From 48b7e8b2a0799fb6237599256c585090cbfffa03 Mon Sep 17 00:00:00 2001 From: zhilingc Date: Wed, 20 Nov 2019 16:20:24 +0800 Subject: [PATCH 2/2] Change port to 9125 --- core/src/main/resources/application.yml | 2 +- infra/charts/feast/charts/feast-core/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/resources/application.yml b/core/src/main/resources/application.yml index 6af41db4fbd..ed11d6c9ebf 100644 --- a/core/src/main/resources/application.yml +++ b/core/src/main/resources/application.yml @@ -38,7 +38,7 @@ feast: # Host of the metrics sink. host: localhost # Port of the metrics sink. - port: 8125 + port: 9125 stream: # Feature stream type. Only kafka is supported. diff --git a/infra/charts/feast/charts/feast-core/values.yaml b/infra/charts/feast/charts/feast-core/values.yaml index 87a510737eb..db1f2f5bbd5 100644 --- a/infra/charts/feast/charts/feast-core/values.yaml +++ b/infra/charts/feast/charts/feast-core/values.yaml @@ -66,7 +66,7 @@ application.yaml: enabled: false type: statsd host: localhost - port: 8125 + port: 9125 stream: type: kafka options: