Skip to content

Bump Beam SDK to 2.9.0#43

Merged
feast-ci-bot merged 2 commits into
masterfrom
bump_beam_sdk
Jan 7, 2019
Merged

Bump Beam SDK to 2.9.0#43
feast-ci-bot merged 2 commits into
masterfrom
bump_beam_sdk

Conversation

@pradithya
Copy link
Copy Markdown
Collaborator

Upgrade Beam SDK to 2.9.0.
As a result following dependencies are update as well:

  1. bigtable-hbase-beam: 1.6.0 -> 1.8.0
  2. io.grpc.grpc-netty: 1.2.0 -> 1.13.1
  3. io.grpc.grpc-stub: 1.2.0 -> 1.13.1
  4. io.grpc.grpc-protobuf: 1.2.0 -> 1.13.1

Fix #42

@pradithya pradithya requested a review from tims January 7, 2019 05:33
Copy link
Copy Markdown
Contributor

@tims tims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change profobuf-java to inherit protobufVersion while you're at it?

<dependency>
       <groupId>com.google.protobuf</groupId>
       <artifactId>protobuf-java</artifactId>
-      <version>3.4.0</version>
+      <version>${protobufVersion}</version>
     </dependency>

@woop
Copy link
Copy Markdown
Member

woop commented Jan 7, 2019

/lgtm

@tims, can you confirm that this doesnt break anything?

@feast-ci-bot feast-ci-bot removed the lgtm label Jan 7, 2019
@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 7, 2019

/lgtm /approve

@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 7, 2019

/lgtm

@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 7, 2019

/lgtm why you no work?

@tims
Copy link
Copy Markdown
Contributor

tims commented Jan 7, 2019

/approve why you no work?

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 7d4eb26 into master Jan 7, 2019
@tims tims deleted the bump_beam_sdk branch January 7, 2019 06:10
aniketpalu pushed a commit to aniketpalu/feast that referenced this pull request Nov 24, 2025
…onflux-replicator-v0.53.0-1756702303

Update Tekton files to version v0.53.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants