Skip to content

Replacing Jedis With Lettuce in ingestion and serving#485

Merged
feast-ci-bot merged 10 commits into
feast-dev:masterfrom
lavkesh:master
Feb 27, 2020
Merged

Replacing Jedis With Lettuce in ingestion and serving#485
feast-ci-bot merged 10 commits into
feast-dev:masterfrom
lavkesh:master

Conversation

@lavkesh
Copy link
Copy Markdown
Contributor

@lavkesh lavkesh commented Feb 22, 2020 •
edited
Loading

This PR replaces the Jedis library with lettuce.
#247

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Feb 22, 2020

Hi @lavkesh. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Copy Markdown
Member

woop commented Feb 23, 2020

/ok-to-test

@lavkesh lavkesh changed the title Replacing Jedis With Lettuce in ingestion Replacing Jedis With Lettuce in ingestion and serving Feb 23, 2020
@lavkesh
Copy link
Copy Markdown
Contributor Author

lavkesh commented Feb 23, 2020

replaced jedis with lettuce in Serving too.

zhilingc
zhilingc reviewed Feb 23, 2020
View reviewed changes
Comment thread ingestion/src/main/java/feast/store/serving/redis/RedisCustomIO.java Outdated
@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Feb 23, 2020

Thanks for this! Batch test is failing because of this: http://prow.feast.ai/view/gcs/feast-templocation-kf-feast/pr-logs/pull/gojek_feast/485/test-end-to-end-batch/1231523469745721350#1:build-log.txt%3A236

@lavkesh
Copy link
Copy Markdown
Contributor Author

lavkesh commented Feb 23, 2020

Thanks for this! Batch test is failing because of this: http://prow.feast.ai/view/gcs/feast-templocation-kf-feast/pr-logs/pull/gojek_feast/485/test-end-to-end-batch/1231523469745721350#1:build-log.txt%3A236

Yeah. Fixing it.!

@lavkesh lavkesh force-pushed the master branch 5 times, most recently from a577632 to 12410e3 Compare February 23, 2020 13:59
@zhilingc
Copy link
Copy Markdown
Collaborator

zhilingc commented Feb 24, 2020

/lgtm

woop
woop reviewed Feb 24, 2020
View reviewed changes
Comment thread serving/src/main/java/feast/serving/configuration/JobServiceConfig.java Outdated
woop
woop reviewed Feb 24, 2020
View reviewed changes
Comment thread serving/src/main/java/feast/serving/configuration/JobServiceConfig.java Outdated
woop
woop reviewed Feb 24, 2020
View reviewed changes
Comment thread serving/src/main/java/feast/serving/configuration/JobServiceConfig.java Outdated
woop
woop reviewed Feb 24, 2020
View reviewed changes
Comment thread serving/src/main/java/feast/serving/configuration/LettuceConfig.java Outdated
woop
woop requested changes Feb 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@woop woop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, please have a look. Overall it looks ok!

@woop
Copy link
Copy Markdown
Member

woop commented Feb 25, 2020

/retest

@woop
Copy link
Copy Markdown
Member

woop commented Feb 25, 2020

/approve
/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Feb 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavkesh, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop woop removed the lgtm label Feb 25, 2020
woop
woop reviewed Feb 25, 2020
View reviewed changes
Comment thread ingestion/src/main/java/feast/store/serving/redis/RedisCustomIO.java Outdated
woop
woop reviewed Feb 25, 2020
View reviewed changes
Comment thread ingestion/src/test/java/feast/store/serving/redis/RedisCustomIOTest.java
woop
woop reviewed Feb 25, 2020
View reviewed changes
Comment thread serving/src/main/java/feast/serving/configuration/redis/JobStoreRedisConfig.java Outdated
woop
woop reviewed Feb 25, 2020
View reviewed changes
Comment thread ingestion/src/main/java/feast/store/serving/redis/RedisCustomIO.java Outdated
@woop
Copy link
Copy Markdown
Member

woop commented Feb 27, 2020

/lgtm

@feast-ci-bot feast-ci-bot merged commit 0b31f27 into feast-dev:master Feb 27, 2020
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Mar 16, 2020
@lavkesh @khorshuheng
Replacing Jedis With Lettuce in ingestion and serving (feast-dev#485)
1cb96f1 
* Replacing Jedis With Lettuce in ingestion and serving

* Removing extra lines

* Abstacting redis connection based on store

* Check the connection before connecting as lettuce does the retry automatically

* Running spotless

* Throw Exception if the job store config is null

* Handle No enum constant RuntimeException
@khorshuheng khorshuheng mentioned this pull request Mar 16, 2020
Merged
khorshuheng pushed a commit that referenced this pull request Mar 16, 2020
@lavkesh @khorshuheng
Replacing Jedis With Lettuce in ingestion and serving (#485)
517e4c6 
* Replacing Jedis With Lettuce in ingestion and serving

* Removing extra lines

* Abstacting redis connection based on store

* Check the connection before connecting as lettuce does the retry automatically

* Running spotless

* Throw Exception if the job store config is null

* Handle No enum constant RuntimeException
@khorshuheng khorshuheng mentioned this pull request Mar 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woop woop woop requested changes

@zhilingc zhilingc zhilingc left review comments

@pradithya pradithya Awaiting requested review from pradithya

Assignees

@woop woop

@zhilingc zhilingc

Labels

approved lgtm ok-to-test size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lavkesh @feast-ci-bot @woop @zhilingc