Docker compose bug fix #661
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There is one concern though - host network mode only works on Linux host machine. Mac users will not be able to use this. |
Damnit I keep forgetting about that limitation. Isn't there a workaround that doesnt involve using private networks? |
|
The workaround i used personally, is to do port mapping on 9092 for Kafka. If i want to test using local jupyter notebook, i edit my etc hosts such that kafka:9092 points to localhost:9092 (so that it matches the advertised listener host). I do agree this is not a pretty workaround, though. |
5cb864b to
58dcc50
Compare
|
Removed host networking. |
What this PR does / why we need it:
Change docker compose file to use host based. This avoids having an inconsistency between default configuration and docker compose configuration.Which issue(s) this PR fixes:
Hopefully fixes all bugs in #652, but more changes are required to close the issue
Does this PR introduce a user-facing change?: