Skip to content

Remove feature set status check for job update requirement #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhilingc merged 1 commit into from
May 15, 2020
Merged

Remove feature set status check for job update requirement #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions core/src/main/java/feast/core/job/JobUpdateTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package feast.core.job;

import com.google.common.collect.Sets;
import feast.core.FeatureSetProto.FeatureSetStatus;
import feast.core.log.Action;
import feast.core.log.AuditLogger;
import feast.core.log.Resource;
Expand Down Expand Up @@ -103,17 +102,7 @@ public Job call() {

boolean requiresUpdate(Job job) {
// If set of feature sets has changed
if (!Sets.newHashSet(featureSets).equals(Sets.newHashSet(job.getFeatureSets()))) {
return true;
}

// If any existing feature set populated by the job has its status as pending
for (FeatureSet featureSet : job.getFeatureSets()) {
if (featureSet.getStatus().equals(FeatureSetStatus.STATUS_PENDING)) {
return true;
}
}
return false;
return !Sets.newHashSet(featureSets).equals(Sets.newHashSet(job.getFeatureSets()));
}

private Job createJob() {
Expand Down