Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 46c757b

Browse files
authored
[dart_runner] Common libs need to exist for aot runner (#13419)
This is to account for failures like: ``` 00067.522] 13245:13247> [00067.522] 13245:13247> ------------------------------------------------ [00067.522] 13245:13247> RUNNING TEST: /pkgfs/packages/goodbye_dart_test/0/test/goodbye_dart_test [00067.522] 13245:13247> [00067.754] 05775:06330> dlsvc: could not open 'ld.so.1' [00067.758] 01149:01207> [component_manager] WARN: Failed to launch process 'dart_aot_runner.cmx' in job 163427: Failed to load dynamic linker from fuchsia.ldsvc.Loader: NOT_FOUND [00067.759] 05775:05777> [ERROR:src/sys/appmgr/realm.cc(155)] Cannot run executable dart_aot_runner.cmx due to error -1 (ZX_ERR_INTERNAL): fuchsia.process.Launcher failed [00067.759] 05775:05777> [ERROR:src/sys/appmgr/runner_holder.cc(41)] Runner (fuchsia-pkg://fuchsia.com/dart_aot_runner#meta/dart_aot_runner.cmx) terminating, reason: failed to create component (UNKNOWN) [00067.760] 13245:13247> fuchsia-pkg://fuchsia.con/goodbye_dart_aot#meta/goodbye_dart_aot.cmx: failed to create component (UNKNOWN) [00067.761] 13245:13247> goodbye_dart_aot --now failed [00067.772] 13245:13247> FAILURE: /pkgfs/packages/goodbye_dart_test/0/test/goodbye_dart_test exited with nonzero status: 1 [00067.886] 13245:13247> [00067.887] 13245:13247> ------------------------------------------------ ``` logs: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket.appspot.com/8898242024940777936/+/steps/launch_collect/0/steps/1/0/steps/collect/0/logs/task_stdout_stderr:_QEMU/0
1 parent 2ebd9db commit 46c757b

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • shell/platform/fuchsia/dart_runner

shell/platform/fuchsia/dart_runner/BUILD.gn

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ template("aot_runner_package") {
153153
},
154154
]
155155

156+
libraries = common_libs
157+
156158
resources = []
157159
if (!invoker.product) {
158160
vmservice_data = rebase_path(

0 commit comments

Comments
 (0)