This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP-stable]Add a check for the surface if it is valid#56301
Merged
Conversation
Fixes an issue where the Surface is not valid and the `draw` method is crashing. flutter/flutter#155018 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
flutteractionsbot
added
the
cp: review
Author
|
@AlexV525 please fill out the PR description above, afterwards the release team will review this request. |
reidbaker
approved these changes
Nov 12, 2024
Contributor
|
I am approving but if @jonahwilliams disagrees then his opinion should take weight over mine. |
jonahwilliams
approved these changes
Nov 12, 2024
jonahwilliams
left a comment
jonahwilliams
left a comment
Contributor
There was a problem hiding this comment.
Change seems safe enough.
LGTM
eyebrowsoffire
added
the
autosubmit
auto-submit
Bot
merged commit c21a11e
into
flutter-team-archive:flutter-3.24-candidate.0
auto-submit
Bot
removed
the
autosubmit
|
Should I request a CP for the framework? Does any automatic workflow manage it? |
Contributor
|
@AlexV525 the engine changes to this branch will automatically be rolled in by the release engineer. Who is @eyebrowsoffire for this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Issue Link:
flutter/flutter#155018
Changelog Description:
Summary:
A crash in Flutter SDK 3.24.1 affects Android apps using PlatformView, not limited to Google Maps. The crash occurs when the surface is released unexpectedly, causing subsequent draw calls to fail.
Impact Description:
Summary:
A crash in Flutter SDK 3.24.3 affects Android apps using
PlatformView, not limited to Google Maps. The crash occurs when the surface is released unexpectedly, causing subsequent draw calls to fail.Impact:
This issue can lead to app crashes on Android for any
PlatformViewusage, affecting stability across a range of widgets and plugins that rely on native views.Workaround:
Is there a workaround for this issue?
Release the
Surfacein a regular way might avoid the issue, per flutter/flutter#155018 (comment)Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?