Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 4db64de

Browse files
authored
Merge branch 'master' into google-maps-traffic
2 parents dd4f890 + 5be4fec commit 4db64de

File tree

9 files changed

+24
-9
lines changed

9 files changed

+24
-9
lines changed

packages/google_maps_flutter/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
* Adds support for toggling the traffic layer
44

5+
## 0.5.19+1
6+
7+
* Fix polyline width according to device density
8+
59
## 0.5.19
610

711

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ final class GoogleMapController
106106
this.registrarActivityHashCode = registrar.activity().hashCode();
107107
this.markersController = new MarkersController(methodChannel);
108108
this.polygonsController = new PolygonsController(methodChannel);
109-
this.polylinesController = new PolylinesController(methodChannel);
109+
this.polylinesController = new PolylinesController(methodChannel, density);
110110
this.circlesController = new CirclesController(methodChannel);
111111
}
112112

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylineController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ class PolylineController implements PolylineOptionsSink {
1111
private final Polyline polyline;
1212
private final String googleMapsPolylineId;
1313
private boolean consumeTapEvents;
14+
private final float density;
1415

15-
PolylineController(Polyline polyline, boolean consumeTapEvents) {
16+
PolylineController(Polyline polyline, boolean consumeTapEvents, float density) {
1617
this.polyline = polyline;
1718
this.consumeTapEvents = consumeTapEvents;
19+
this.density = density;
1820
this.googleMapsPolylineId = polyline.getId();
1921
}
2022

@@ -70,7 +72,7 @@ public void setVisible(boolean visible) {
7072

7173
@Override
7274
public void setWidth(float width) {
73-
polyline.setWidth(width);
75+
polyline.setWidth(width * density);
7476
}
7577

7678
@Override

packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,13 @@ class PolylinesController {
1818
private final Map<String, String> googleMapsPolylineIdToDartPolylineId;
1919
private final MethodChannel methodChannel;
2020
private GoogleMap googleMap;
21+
private final float density;
2122

22-
PolylinesController(MethodChannel methodChannel) {
23+
PolylinesController(MethodChannel methodChannel, float density) {
2324
this.polylineIdToController = new HashMap<>();
2425
this.googleMapsPolylineIdToDartPolylineId = new HashMap<>();
2526
this.methodChannel = methodChannel;
27+
this.density = density;
2628
}
2729

2830
void setGoogleMap(GoogleMap googleMap) {
@@ -88,7 +90,7 @@ private void addPolyline(Object polyline) {
8890
private void addPolyline(
8991
String polylineId, PolylineOptions polylineOptions, boolean consumeTapEvents) {
9092
final Polyline polyline = googleMap.addPolyline(polylineOptions);
91-
PolylineController controller = new PolylineController(polyline, consumeTapEvents);
93+
PolylineController controller = new PolylineController(polyline, consumeTapEvents, density);
9294
polylineIdToController.put(polylineId, controller);
9395
googleMapsPolylineIdToDartPolylineId.put(polyline.getId(), polylineId);
9496
}

packages/google_maps_flutter/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: google_maps_flutter
22
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
33
author: Flutter Team <flutter-dev@googlegroups.com>
44
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter
5-
version: 0.5.19
5+
version: 0.5.19+1
66

77
dependencies:
88
flutter:

packages/local_auth/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 0.5.2+3
2+
* Update documentation to clarify the need for FragmentActivity.
3+
14
## 0.5.2+2
25

36
* Add missing template type parameter to `invokeMethod` calls.

packages/local_auth/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ app has not been updated to use TouchID.
127127

128128
## Android Integration
129129

130+
Note that local_auth plugin requires the use of a FragmentActivity as
131+
opposed to Activity. This can be easily done by switching to use
132+
`FlutterFragmentActivity` as opposed to `FlutterActivity` in your
133+
manifest (or your own Activity class if you are extending the base class).
134+
130135
Update your project's `AndroidManifest.xml` file to include the
131136
`USE_FINGERPRINT` permissions:
132137

packages/local_auth/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Android and iOS device authentication sensors
33
such as Fingerprint Reader and Touch ID.
44
author: Flutter Team <flutter-dev@googlegroups.com>
55
homepage: https://github.com/flutter/plugins/tree/master/packages/local_auth
6-
version: 0.5.2+2
6+
version: 0.5.2+3
77

88
flutter:
99
plugin:

script/incremental_build.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ else
2121
check_changed_packages
2222

2323
if [[ "$CHANGED_PACKAGES" == "" ]]; then
24-
echo "Running for all packages"
25-
(cd "$REPO_DIR" && pub global run flutter_plugin_tools "${ACTIONS[@]}" $PLUGIN_SHARDING)
24+
echo "No changes detected in packages."
2625
else
2726
(cd "$REPO_DIR" && pub global run flutter_plugin_tools "${ACTIONS[@]}" --plugins="$CHANGED_PACKAGES" $PLUGIN_SHARDING)
2827
fi

0 commit comments

Comments
 (0)