[firebase_crashlytics] Handle case where function isn't in class for stack (#1831)

* Handle case where no class in dart and android (ios is fine)

Author: rmtmckenzie

packages/firebase_crashlytics/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.0.4+11
+
+* Fixed an issue where `Crashlytics#getStackTraceElements` didn't handle functions without classes.
+
 ## 0.0.4+10
 
 * Update README.

packages/firebase_crashlytics/android/src/main/java/io/flutter/plugins/firebase/crashlytics/firebasecrashlytics/FirebaseCrashlyticsPlugin.java

@@ -103,7 +103,8 @@ private StackTraceElement generateStackTraceElement(Map<String, String> errorEle
       String className = errorElement.get("class");
       String methodName = errorElement.get("method");
 
-      return new StackTraceElement(className, methodName, fileName, Integer.parseInt(lineNumber));
+      return new StackTraceElement(
+          className == null ? "" : className, methodName, fileName, Integer.parseInt(lineNumber));
     } catch (Exception e) {
       Log.e(TAG, "Unable to generate stack trace element from Dart side error.");
       return null;

packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart

@@ -171,17 +171,25 @@ class Crashlytics {
         final String lineNumber = lineParts[1].contains(":")
             ? lineParts[1].substring(0, lineParts[1].indexOf(":")).trim()
             : lineParts[1];
-        final String className =
-            lineParts[2].substring(0, lineParts[2].indexOf(".")).trim();
-        final String methodName =
-            lineParts[2].substring(lineParts[2].indexOf(".") + 1).trim();
-
-        elements.add(<String, String>{
-          'class': className,
-          'method': methodName,
+
+        final Map<String, String> element = <String, String>{
           'file': fileName,
           'line': lineNumber,
-        });
+        };
+
+        if (lineParts[2].contains(".")) {
+          final String className =
+              lineParts[2].substring(0, lineParts[2].indexOf(".")).trim();
+          final String methodName =
+              lineParts[2].substring(lineParts[2].indexOf(".") + 1).trim();
+
+          element['class'] = className;
+          element['method'] = methodName;
+        } else {
+          element['method'] = lineParts[2];
+        }
+
+        elements.add(element);
       } catch (e) {
         print(e.toString());
       }

packages/firebase_crashlytics/pubspec.yaml

@@ -1,7 +1,7 @@
 name: firebase_crashlytics
 description: Flutter plugin for Firebase Crashlytics. It reports uncaught errors to the
   Firebase console.
-version: 0.0.4+10
+version: 0.0.4+11
 author: Flutter Team <flutter-dev@google.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_crashlytics
 

packages/firebase_crashlytics/test/firebase_crashlytics_test.dart

@@ -142,5 +142,19 @@ void main() {
         'line': '3825',
       });
     });
+
+    test('getStackTraceElements without class', () async {
+      final List<String> lines = <String>[
+        'package:firebase_crashlytics/test/main.dart 12  main'
+      ];
+      final List<Map<String, String>> elements =
+          crashlytics.getStackTraceElements(lines);
+      expect(elements.length, 1);
+      expect(elements.first, <String, String>{
+        'method': 'main',
+        'file': 'package:firebase_crashlytics/test/main.dart',
+        'line': '12',
+      });
+    });
   });
 }