[fix] use fs.unlinkSync#979
Merged
Merged
Conversation
Right now fs.unlink is used without a callback. This would throw from Node.js 10 on. Therefore switch to the sync version. That way errors are also going to be detected.
Contributor
Author
|
Ping @indexzero |
Contributor
Author
Contributor
Author
|
Just a note: forever is broken on Node.js 10 without this fix. @genediazjr @nucleardreamer @indexzero PTAL. This is only a single line and should just be merged. |
Contributor
Author
|
PTAL |
Contributor
|
Thanks! |
kaypeter87
added a commit
to kaypeter87/forever
that referenced
this pull request
Sep 1, 2019
* Execute tests in CI on newer Node.js versions (foreversd#1013) * Add example for referencing -l -o and -e parameters from within a JSON config file (foreversd#869) * [fix] use fs.unlinkSync (foreversd#979) Right now fs.unlink is used without a callback. This would throw from Node.js 10 on. Therefore switch to the sync version. That way errors are also going to be detected. * Remove dependency on timespan (foreversd#1014) * Remove dependency on timespan. Add test to ensure that uptime signature didn't change * Remove redundant description * Propagate error when failing to create directories on startup (foreversd#1017) * Update utile to get rid of security warning (foreversd#1022) * Update utile to get rid of security warning * Don't use external dependencies from utile * [doc] Update contributors. * [dist] Add package-lock.json * [dist] Version bump. 0.15.4 * [dist] Version bump. 1.0.0 * Update changelog for 1.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now fs.unlink is used without a callback. This would throw
from Node.js 10 on. Therefore switch to the sync version. That way
errors are also going to be detected.
See nodejs/node#18668