Skip to content

Fix AvoidSinglePipeOperator false negative #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knocte merged 3 commits into from
Feb 12, 2024
Merged

Fix AvoidSinglePipeOperator false negative #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98cb562
Tests.Core: add a failure test
Mersho Feb 8, 2024
f78d63e
AvoidSinglePipeOperator: apply fix
Mersho Feb 12, 2024
0b25137
Tests(AvoidSinglePipeOperator): add more tests
Mersho Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 23 additions & 18 deletions src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,35 @@ let runner (args: AstNodeRuleParams) =
SuggestedFix = None
TypeChecks = List.Empty
} |> Array.singleton

let checkExpr (expr: SynExpr) =
match expr with
| SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, argExpr, _range) ->
match funcExpr with
| ExpressionUtilities.Identifier([ ident ], _) ->
if ident.idText = "op_PipeRight" then
match argExpr with
| SynExpr.App(_exprAtomicFlag, _isInfix, _funcExpr, _argExpr, _range) ->
Array.empty
| SynExpr.IfThenElse _ ->
Array.empty
| _ ->
errors ident.idRange
else
Array.empty
| _ ->
Array.empty
| _ ->
Array.empty

let error =
match args.AstNode with
| AstNode.Binding (SynBinding(_synAcc, _synBinding, _mustInline, _isMut, _synAttribs, _preXmlDoc, _synValData, _headPat, _synBindingRet, synExpr, _range, _debugPointAtBinding, _)) ->
match synExpr with
| SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, _argExpr, _range) ->
match funcExpr with
| SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, argExpr, _range) ->
match funcExpr with
| ExpressionUtilities.Identifier([ ident ], _) ->
if ident.idText = "op_PipeRight" then
match argExpr with
| SynExpr.App(_exprAtomicFlag, _isInfix, _funcExpr, _argExpr, _range) ->
Array.empty
| SynExpr.IfThenElse _ ->
Array.empty
| _ ->
errors ident.idRange
else
Array.empty
| _ ->
Array.empty
| _ ->
Array.empty
checkExpr funcExpr
| SynExpr.IfThenElse(_, SynExpr.App(_exprAtomicFlag, _isInfix, funcExpr, _argExpr, _range), _, _, _, _, _) ->
checkExpr funcExpr
| _ ->
Array.empty
| _ ->
Expand Down
36 changes: 36 additions & 0 deletions tests/FSharpLint.Core.Tests/Rules/Conventions/AvoidSinglePipeOperator.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,39 @@ let foo param =
"""

Assert.True this.NoErrorsExist

[<Test>]
member this.``Use pipe operator once on record``() =
this.Parse """
type Person =
{
FirstName: string
}

let someFunc someParam =
if someParam then
{ FirstName = "Bar" } |> someOtherFunc
else
Array.empty
"""

Assert.IsTrue this.ErrorsExist

[<Test>]
member this.``Use pipe operator twice on record``() =
this.Parse """
type Person =
{
FirstName: string
}

let someFunc someParam =
if someParam then
{ FirstName = "Bar" }
|> someOtherFunc
|> yetAnotherFunc
else
Array.empty
"""

Assert.IsTrue this.NoErrorsExist