Compatibility with f#+ 1 test by wallymathieu · Pull Request #303 · fsprojects/FSharpPlus

wallymathieu · 2020-03-23T07:24:10Z

Compatibility

FSharpPlus.Builders.StrictBuilder

  + (Instance of FSharpPlus.Builders.StrictBuilder).Using : 
          disposable:'A * body:FSharpFunc<'A,'B>
          -> 'B

  - (Instance of FSharpPlus.Builders.StrictBuilder).Using : 
          disposable:'A * body:FSharpFunc<Microsoft.FSharp.Core.Unit,FSharpFunc<'A,'B>>
          -> 'B

FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T,'E>>>

  - FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T\,'E>>>.Put : 
          x:'S
          -> 'CHOICET<'MONADSTATE<'S\,CHOICE<_\,'E>>>

  + FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T\,'E>>>.Put : 
          x:'S
          -> ChoiceT<'MONADSTATE<'S\,CHOICE<_\,'E>>>

  - FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T\,'E>>>.Tell : 
          w:'MONOID
          -> 'CHOICET<WRITER<'MONOID\,CHOICE<UNIT\,'E>>>

  + FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T\,'E>>>.Tell : 
          w:'MONOID
          -> ChoiceT<'WRITER<'MONOID\,CHOICE<UNIT\,'E>>>

  - FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T\,'E>>>.get_Get : 
          System.Void
          -> 'CHOICET<'MONADSTATE<'S\,CHOICE<_\,'E>>>

  + FSharpPlus.Data.ChoiceT<'MONAD<'CHOICE<'T\,'E>>>.get_Get : 
          System.Void
          -> ChoiceT<'MONADSTATE<'S\,CHOICE<_\,'E>>>

FSharpPlus.Data.WriterT<'MONAD<'T * 'MONOID>>

  - FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> 'WRITERT<'MONADASYNC<'T>>

  + FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> WriterT<'MONADASYNC<'T>>

  - FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.Put : 
          x:'S
          -> 'WRITERT<'MONADSTATE<'S\,UNIT\*'MONOID>>

  + FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.Put : 
          x:'S
          -> WriterT<'MONADSTATE<'S\,UNIT\*'MONOID>>

  - FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.Throw : 
          x:'E
          -> 'A

  + FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.Throw : 
          x:'E
          -> WriterT<'A>

  - FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.get_Ask : 
          System.Void
          -> 'WRITERT<'MONADREADER<'R\,'R\*'MONOID>>

  + FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.get_Ask : 
          System.Void
          -> WriterT<'MONADREADER<'R\,'R\*'MONOID>>

  - FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.get_Get : 
          System.Void
          -> 'WRITERT<'MONADSTATE<'S\,'S\*'MONOID>>

  + FSharpPlus.Data.WriterT<'MONAD<'T \* 'MONOID>>.get_Get : 
          System.Void
          -> WriterT<'MONADSTATE<'S\,'S\*'MONOID>>

FSharpPlus.Data.StateT<'S,'MONAD<'T * 'S>>

  - FSharpPlus.Data.StateT<'S,'MONAD<'T \* 'S>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> 'STATET<'S\,'MONADASYNC<'T>>

  + FSharpPlus.Data.StateT<'S,'MONAD<'T \* 'S>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> StateT<'S,'MONADASYNC<'T>>

  - FSharpPlus.Data.StateT<'S,'MONAD<'T \* 'S>>.Throw : 
          x:'E
          -> 'A

  + FSharpPlus.Data.StateT<'S,'MONAD<'T \* 'S>>.Throw : 
          x:'E
          -> StateT<'A,'B>

FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>

  - FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> 'SEQT<'MONADASYNC<'T>>

  + FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> SeqT<'MONADASYNC<'T>>

  + FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.Put : 
          x:'S
          -> SeqT<'MONADSTATE<UNIT\,'S>>

  - FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.Put : 
          x:'T
          -> 'SEQT<'MONADSTATE<UNIT\,'S>>

  - FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.Throw : 
          x:'E
          -> 'A

  + FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.Throw : 
          x:'E
          -> SeqT<'A>

  - FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.get_Ask : 
          System.Void
          -> 'SEQT<'MONADREADER<'R\,SEQ<'R>>>

  + FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.get_Ask : 
          System.Void
          -> SeqT<'MONADREADER<'R\,SEQ<'R>>>

  - FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.get_Get : 
          System.Void
          -> 'SEQT<'MONADSTATE<'S\,'S>>

  + FSharpPlus.Data.SeqT<'MONAD<SEQ<'T>>>.get_Get : 
          System.Void
          -> SeqT<'MONADSTATE<'S\,'S>>

FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T,'E>>>

  - FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> 'RESULTT<'MONADASYNC<'T>>

  + FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> ResultT<'MONADASYNC<'T>>

  - FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.Put : 
          x:'S
          -> 'RESULTT<'MONADSTATE<'S\,RESULT<_\,'E>>>

  + FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.Put : 
          x:'S
          -> ResultT<'MONADSTATE<'S\,RESULT<_\,'E>>>

  - FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.Tell : 
          w:'MONOID
          -> 'RESULTT<WRITER<'MONOID\,RESULT<UNIT\,'E>>>

  + FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.Tell : 
          w:'MONOID
          -> ResultT<'WRITER<'MONOID\,RESULT<UNIT\,'E>>>

  - FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.get_Get : 
          System.Void
          -> 'RESULTT<'MONADSTATE<'S\,RESULT<_\,'E>>>

  + FSharpPlus.Data.ResultT<'MONAD<'RESULT<'T\,'E>>>.get_Get : 
          System.Void
          -> ResultT<'MONADSTATE<'S\,RESULT<_\,'E>>>

FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>

  - FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> 'OPTIONT<'MONADASYNC<'T>>

  + FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> OptionT<'MONADASYNC<'T>>

  + FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.Put : 
          x:'S
          -> OptionT<'MONADSTATE<UNIT\,'S>>

  - FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.Put : 
          x:'T
          -> 'OPTIONT<'MONADSTATE<UNIT\,'S>>

  - FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.Tell : 
          w:'MONOID
          -> 'OPTIONT<'MONADWRITER<'MONOID\, UNIT>>

  + FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.Tell : 
          w:'MONOID
          -> OptionT<'MONADWRITER<'MONOID\, UNIT>>

  - FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.Throw : 
          x:'E
          -> 'A

  + FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.Throw : 
          x:'E
          -> OptionT<'A>

  - FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.get_Ask : 
          System.Void
          -> 'OPTIONT<'MONADREADER<'R\,OPTION<'R>>>

  + FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.get_Ask : 
          System.Void
          -> OptionT<'MONADREADER<'R\,OPTION<'R>>>

  - FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.get_Get : 
          System.Void
          -> 'OPTIONT<'MONADSTATE<'S\,'S>>

  + FSharpPlus.Data.OptionT<'MONAD<OPTION<'T>>>.get_Get : 
          System.Void
          -> OptionT<'MONADSTATE<'S\,'S>>

FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>

  - FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> 'LISTT<'MONADASYNC<'T>>

  + FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.LiftAsync : 
          x:FSharpAsync<'T>
          -> ListT<'MONADASYNC<'T>>

  + FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.Put : 
          x:'S
          -> ListT<'MONADSTATE<UNIT\,'S>>

  - FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.Put : 
          x:'T
          -> 'LISTT<'MONADSTATE<UNIT\,'S>>

  - FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.Throw : 
          x:'E
          -> 'A

  + FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.Throw : 
          x:'E
          -> ListT<'A>

  - FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.get_Ask : 
          System.Void
          -> 'LISTT<'MONADREADER<'R\,  LIST<'R>>>

  + FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.get_Ask : 
          System.Void
          -> ListT<'MONADREADER<'R\,  LIST<'R>>>

  - FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.get_Get : 
          System.Void
          -> 'LISTT<'MONADSTATE<'S\,'S>>

  + FSharpPlus.Data.ListT<'MONAD<LIST<'T>>>.get_Get : 
          System.Void
          -> ListT<'MONADSTATE<'S\,'S>>

FSharpPlus.Data.DList<'T>

  - FSharpPlus.Data.DList<'T>.get_Empty : 
          FSharpPlus.Data.DList<System.Object>

  + FSharpPlus.Data.DList<'T>.get_Empty : 
          System.Void
          -> DList<'A>

  - FSharpPlus.Data.DList<'T>.get_Zero : 
          FSharpPlus.Data.DList<System.Object>

  + FSharpPlus.Data.DList<'T>.get_Zero : 
          System.Void
          -> DList<'A>

This reverts commit 514ecd4.

gusty

I had a quick look.
If this solves the compatibility problem, we can return to our original plan of releasing all these new features under 1.1
I'll continue reviewing it.

wallymathieu · 2020-03-26T05:56:03Z

I'm thinking to add more tests in order to verify this solves compatibility

gusty

I'm OK with this.
You can merge it when you feel it's ready to go.

wallymathieu added 3 commits March 23, 2020 07:38

Add lib that uses f#+ 1

48d4b9c

Test of compatibility

998cb44

f# core version

d1f475c

wallymathieu changed the title ~~Test of using 1~~ Compatibility with f#+ 1 test Mar 23, 2020

wallymathieu added 3 commits March 23, 2020 18:50

+Compatibility with 1.0.0

dcb3b00

Obsolete map methods

34eae9c

Not supposed to be added

033e899

wallymathieu changed the base branch from master to v1.1.0 March 24, 2020 07:29

wallymathieu added 4 commits March 24, 2020 08:30

Revert "Less generic signature for Exchange"

50ed97d

This reverts commit 514ecd4.

Adding Obsolete members

c7e3327

+Compatibility

510ecb8

Lens internals

aa8309f

wallymathieu marked this pull request as ready for review March 25, 2020 19:19

wallymathieu requested a review from gusty March 25, 2020 19:20

gusty reviewed Mar 26, 2020

View reviewed changes

wallymathieu added 11 commits March 26, 2020 08:26

Copy validations tests

2afd679

+Lenses and extensions

de2a003

-Extensions

90a6349

Test Fleece compiled against 1.0 with 1.1

e4c28fb

return value need to be ignored

9a50dfb

+General tests

b64fd9d

Not a relevant failure

4b85a65

revert Array.replace fix

139471d

+Non overloading legacy method

e0ba568

+Legacy Traverse, renamed TryItemX to TryItemLegacy

a99bcea

+Legacy Length methods

b4a3be7

wallymathieu requested a review from gusty March 28, 2020 10:17

gusty approved these changes Mar 28, 2020

View reviewed changes

wallymathieu merged commit d2afb82 into fsprojects:v1.1.0 Mar 28, 2020

wallymathieu deleted the test-of-using-1 branch March 28, 2020 18:01

wallymathieu mentioned this pull request Nov 13, 2022

Array.replace takes in seq for its two first values instead of arrays #514

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compatibility with f#+ 1 test#303

Compatibility with f#+ 1 test#303
wallymathieu merged 21 commits into
fsprojects:v1.1.0from
wallymathieu:test-of-using-1

wallymathieu commented Mar 23, 2020 •

edited

Loading

Uh oh!

gusty left a comment

Uh oh!

wallymathieu commented Mar 26, 2020

Uh oh!

gusty left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

wallymathieu commented Mar 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility

Uh oh!

gusty left a comment

Choose a reason for hiding this comment

Uh oh!

wallymathieu commented Mar 26, 2020

Uh oh!

gusty left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wallymathieu commented Mar 23, 2020 •

edited

Loading