V1.3 F# core 6#513
Merged
Merged
Conversation
New, shiny links (who work) =D
…here (#488) - updateAt from F# Core 6 - Option module (nothing to update) - List.singleton // check if it worth linking to the fsharp.core one, in anycase copy type annotations and XML contents - List.skip - List.take - List.removeAt - Map.values // but it returns an ICollection - Map.keys // but it returns an ICollection - Result.result and Result.throw should be deprecated in favor of Result.Ok and Result.Error - Seq.foldBack - Seq.replicate - Result.defaultValue - Result.defaultWith Co-authored-by: Oskar Gewalli <wallymathieu@users.noreply.github.com> Co-authored-by: Gustavo Leon <1261319+gusty@users.noreply.github.com>
Merge commit '38f6bc73b6148bfff2a76a651bd9d226786b3528' into v1.3
Merge commit '866c19ddf8bb89c8aecff83b9fcb1c52f6426dc2' into v1.3
Merge commit 'c56866ca88079786969dfffb924be38f6472dda5' into v1.3
wallymathieu
commented
Nov 13, 2022
| #if FABLE_COMPILER || NET45 | ||
| source |> Array.toSeq |> Seq.replace oldValue newValue |> Seq.toArray: 'T [] | ||
| #else | ||
| let oldValueArray = oldValue |> Seq.toArray |
Member
Author
There was a problem hiding this comment.
I had to change to toArray here since the actual type signature in the released version of F#+ is seq as can be seen for instance here:
https://www.fuget.org/packages/FSharpPlus/1.2.5/lib/netstandard2.0/FSharpPlus.dll/FSharpPlus/Array
@fcallejon
wallymathieu
commented
Nov 13, 2022
| /// A tuple with both resulting lists, Success are in the first list. | ||
| /// </returns> | ||
| let partition (source: list<Validation<'TErrors, 'T>>) = | ||
| #if FABLE_COMPILER || NET45 |
Member
Author
There was a problem hiding this comment.
Note that both net45 and Fable lack ListCollector @gusty
Co-authored-by: Fernando Callejon <fcallejon@gmail.comn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.