[Breaking] Updates to uglify v3.#31
Merged
Merged
Conversation
bbrzoska
reviewed
Jul 11, 2017
| "pify": "^3.0.0", | ||
| "tmp": "0.0.29", | ||
| "uglify-js": "^2.6.2", | ||
| "uglify-js": "^3.0.21", |
There was a problem hiding this comment.
Could you make uglify-js a peerDependency so we can use custom versions? Also, it might be better to use uglify-es, since it's a superset of uglify-js with additional support for ES6? Thanks!
Owner
Author
There was a problem hiding this comment.
The current plan is to support both uglify-js and uglify-es to allow users to build both es6 and es5 versions of their code. This'll be done by listing both in devDependencies and then using whichever is specified in the plugin.
gdborton
force-pushed
the
update-to-uglifyJS3
branch
from
ace6db9 to
0fa5e7c
Compare
This is a breaking change as we allow our users to directly pass options to uglify, and those options have changed in uglify v3. Updating to uglify v3 paves the way for enabling optional es6 support, as uglify-es shares the same api as uglify v3.
gdborton
force-pushed
the
update-to-uglifyJS3
branch
from
0fa5e7c to
6e2f0ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change as we allow our users to directly pass options to
uglify, and those options have changed in uglify v3. Updating to uglify v3
paves the way for enabling optional es6 support, as uglify-es shares the same
api as uglify v3.