Skip to content

Commit 25d7af0

Browse files
committed
correct semantic for push
1 parent e3eb726 commit 25d7af0

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/docker.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ jobs:
127127
- name: Build & Push
128128
uses: docker/build-push-action@v5
129129
with:
130-
# pull always to ensure we have the latest base image
130+
# ensure we have the latest base image
131131
pull: true
132132
# force a full rebuild regardless of any local cache from previous workflow runs
133133
no-cache: true
@@ -136,7 +136,7 @@ jobs:
136136
context: .
137137
file: ./Dockerfile.generated
138138
platforms: ${{ matrix.platform }}
139-
push: ${{ always() }}
139+
push: true
140140
# Add suffix to the arch-specific image tag
141141
tags: ${{ steps.meta.outputs.tags }}${{ matrix.suffix }}
142142
labels: ${{ steps.meta.outputs.labels }}
@@ -158,7 +158,6 @@ jobs:
158158
outputs: type=local,dest=${{ runner.temp }}/artifacts/${{ matrix.logs_dir }}
159159

160160
- name: Upload logs artifact
161-
if: ${{ always() }}
162161
uses: actions/upload-artifact@v4
163162
with:
164163
name: logs-${{ matrix.gemc_tag }}-${{ matrix.geant4_tag }}-${{ matrix.image }}-${{ matrix.arch }}
@@ -212,7 +211,6 @@ jobs:
212211
fi
213212
214213
- name: Summary (manifest)
215-
if: ${{ always() }}
216214
shell: bash
217215
env:
218216
IMAGE: ${{ needs.discover.outputs.image }}

0 commit comments

Comments
 (0)