Skip to content

feat(py-client): Add Multipart Upload API#476

Open
lcian wants to merge 22 commits into
lcian/feat/multipart-upload-rust-clientfrom
lcian/feat/multipart-upload-python-client
Open

feat(py-client): Add Multipart Upload API#476
lcian wants to merge 22 commits into
lcian/feat/multipart-upload-rust-clientfrom
lcian/feat/multipart-upload-python-client

Conversation

@lcian
Copy link
Copy Markdown
Member

@lcian lcian commented May 12, 2026

⚠️ Stacked on #468

Adds a Multipart Upload API to the Python client.
The API is basically the same as the one implemented in #468 for the Rust client.

Close FS-340

@lcian lcian changed the base branch from main to lcian/feat/multipart-upload-rust-client May 12, 2026 14:29
@lcian lcian changed the title lcian/feat/multipart upload python client feat(py-client): Add Multipart Upload API May 12, 2026
@lcian

This comment was marked as outdated.

@lcian

This comment was marked as outdated.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 08f34e3. Configure here.

@lcian

This comment was marked as outdated.

@lcian

This comment was marked as outdated.

Comment thread clients/python/src/objectstore_client/client.py
Comment thread clients/python/src/objectstore_client/multipart.py
@lcian

This comment was marked as outdated.

@lcian

This comment was marked as outdated.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 15, 2026

FS-340

cursor[bot]

This comment was marked as outdated.

@lcian lcian marked this pull request as ready for review May 15, 2026 13:13
@lcian lcian requested a review from a team as a code owner May 15, 2026 13:13
@lcian lcian requested a review from matt-codecov May 15, 2026 16:37
@lcian lcian force-pushed the lcian/feat/multipart-upload-rust-client branch from 93557e1 to 84181ed Compare May 15, 2026 17:01
lcian added 13 commits May 15, 2026 19:05
- Fix sphinx doc build: suppress ambiguous cross-reference warnings
  for re-exported symbols and use fully qualified references
- Fix inconsistent metric operation name: multipart_complete -> multipart.complete
- Fix line-too-long and typo in docstrings
lcian added 9 commits May 15, 2026 19:05
The ref.python suppression is needed because Session is re-exported
from __init__.py, causing ambiguous cross-reference warnings with -W.
Also update auto-generated rst to include errors and multipart modules.
Set __module__ on re-exported classes in __init__.py so Sphinx sees a
single canonical target, instead of suppressing all ref.python warnings.
Clear __all__ on the top-level package during doc generation so
re-exported symbols only have a single Sphinx target (under their
defining submodule). Replaces both the suppress_warnings blanket
and the __module__ hack.
ref.python is the most specific suppression Sphinx supports for
the duplicate-target warning caused by re-exports in __init__.py.
@lcian lcian force-pushed the lcian/feat/multipart-upload-python-client branch from 6ac7e3c to 11acbc3 Compare May 15, 2026 17:05
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 93.29268% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (84181ed) to head (11acbc3).

Files with missing lines Patch % Lines
clients/python/src/objectstore_client/multipart.py 91.17% 9 Missing ⚠️
clients/python/src/objectstore_client/client.py 94.87% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           lcian/feat/multipart-upload-rust-client     #476      +/-   ##
===========================================================================
+ Coverage                                    86.94%   87.02%   +0.08%     
===========================================================================
  Files                                           80       82       +2     
  Lines                                        12303    12456     +153     
===========================================================================
+ Hits                                         10697    10840     +143     
- Misses                                        1606     1616      +10     
Components Coverage Δ
Rust Backend 91.74% <ø> (ø)
Rust Client 79.79% <ø> (ø)
Python Client 88.36% <93.29%> (+2.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant