feat(py-client): Add Multipart Upload API#476
Open
lcian wants to merge 22 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 08f34e3. Configure here.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
93557e1 to
84181ed
Compare
- Fix sphinx doc build: suppress ambiguous cross-reference warnings for re-exported symbols and use fully qualified references - Fix inconsistent metric operation name: multipart_complete -> multipart.complete - Fix line-too-long and typo in docstrings
The ref.python suppression is needed because Session is re-exported from __init__.py, causing ambiguous cross-reference warnings with -W. Also update auto-generated rst to include errors and multipart modules.
Set __module__ on re-exported classes in __init__.py so Sphinx sees a single canonical target, instead of suppressing all ref.python warnings.
Clear __all__ on the top-level package during doc generation so re-exported symbols only have a single Sphinx target (under their defining submodule). Replaces both the suppress_warnings blanket and the __module__ hack.
ref.python is the most specific suppression Sphinx supports for the duplicate-target warning caused by re-exports in __init__.py.
6ac7e3c to
11acbc3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## lcian/feat/multipart-upload-rust-client #476 +/- ##
===========================================================================
+ Coverage 86.94% 87.02% +0.08%
===========================================================================
Files 80 82 +2
Lines 12303 12456 +153
===========================================================================
+ Hits 10697 10840 +143
- Misses 1606 1616 +10
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Multipart Upload API to the Python client.
The API is basically the same as the one implemented in #468 for the Rust client.
Close FS-340