fix: Prevent shell injection in GitHub Actions workflow#2110
Open
fix-it-felix-sentry[bot] wants to merge 1 commit into
Open
fix: Prevent shell injection in GitHub Actions workflow#2110fix-it-felix-sentry[bot] wants to merge 1 commit into
fix-it-felix-sentry[bot] wants to merge 1 commit into
Conversation
Use environment variables instead of direct interpolation of GitHub context variables in run steps to prevent potential shell injection attacks. This addresses the security finding by: - Storing github.sha, github.ref, github.actor, matrix.arch, and github.event_name in environment variables - Using quoted environment variables in shell commands instead of direct interpolation - Following GitHub Actions security best practices for script injection prevention Fixes: https://linear.app/getsentry/issue/VULN-1618 Fixes: https://linear.app/getsentry/issue/DI-1912 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security finding by preventing potential shell injection in the GitHub Actions workflow.
Changes
github.sha,github.ref,github.actor,github.event_name) with environment variables${{ }}interpolationloginandbuildstepsThis follows GitHub Actions security best practices for preventing script injection attacks by treating all GitHub context data as potentially untrusted and using intermediate environment variables.
References