Conversation
Member
Author
|
oh hm i feel like validate should respect |
joshuarli
commented
Feb 6, 2024
asottile-sentry
suggested changes
Feb 6, 2024
Comment on lines
11
to
12
| from collections.abc import Mapping | ||
| from typing import NamedTuple |
Contributor
There was a problem hiding this comment.
this file shouldn't be changed -- validate must succeed on all installable targets. otherwise we're building a wheel that is installable but broken
Member
Author
|
will redo this but with salt forked to remove a lot of those weird optional dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds salt-3006 dependencies (excluding salt and cherrypy)
ok so it does appear that we aren't building proper msgpack wheels... before i didn't look too closely and proposed #76 but it's an actual problem - i grabbed wheels from https://github.com/msgpack/msgpack-python/actions/runs/7274351210 and they havenvmmsgpack/_cmsgpack.cpython-310-darwin.soand we don'tupdate we're actually gonna need #76 since salt has apkg/old/smartos/esky/sodium_grabber.c: #644