feat(explore): Add optional index field to AttributeKey for array element access#250
Open
manessaraj wants to merge 4 commits into
Open
Conversation
…ment access Adds `optional sint32 index` on `AttributeKey` to support indexed access into array-typed attributes (e.g. `field[N]:value` syntax). Signed to leave room for negative indexing;
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
onewland
requested changes
May 8, 2026
Contributor
onewland
left a comment
onewland
left a comment
There was a problem hiding this comment.
I don't think we should support negative indexing. I'm actually curious what the use-case is for this overall
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1a8c33. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
optional sint32 indexonAttributeKeyto support indexed access into array-typed attributes (e.g.field[N]:valuesyntax).