feat(billing): added upsert response+request messages(REVENG-78)#257
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 41ca379. Configure here.
| Status status = 2; | ||
| optional string suspension_reason = 3; | ||
| OnDemandStatus ondemand_status = 4; | ||
| } |
There was a problem hiding this comment.
Request duplicates entity fields instead of embedding message
Medium Severity
UpsertAccountStatusRequest duplicates every field from AccountStatus (same types, tags, and optionality) instead of embedding AccountStatus as a nested message — the pattern already used by GetAccountStatusResponse. If AccountStatus gains a new field in the future, it would need to be manually added to this request message as well, risking silent data loss on upserts when the two definitions fall out of sync.
Reviewed by Cursor Bugbot for commit 41ca379. Configure here.
There was a problem hiding this comment.
that's okay, we don't want the caller to need to know the shape of the account status proto
3 participants
https://linear.app/getsentry/issue/REVENG-78/implement-upsert-method-for-accountservice
This PR adds request and response messages for an upsert method for the account service. This method will be the main way to create/update records in the accounts_platformstatus table.