-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(billing): added upsert response+request messages(REVENG-78) #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
41ca379
added upsert response+request messages and tests
krithikravi b6a6c5c
made all fields optional except for org id
krithikravi b105a02
Merge branch 'main' into upsert-account-proto
krithikravi 349174b
chore: Regenerate Rust bindings
getsantry[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
21 changes: 21 additions & 0 deletions
21
.../sentry_protos/billing/v1/services/account_status/v1/endpoint_upsert_account_status.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package sentry_protos.billing.v1.services.account_status.v1; | ||
|
|
||
| import "sentry_protos/billing/v1/services/account_status/v1/account_status.proto"; | ||
|
|
||
| // Creates or updates the account status for an organization. If no record | ||
| // exists for the given organization_id, one is created. If a record already | ||
| // exists, it is updated with the provided fields. | ||
| message UpsertAccountStatusRequest { | ||
| uint64 organization_id = 1; | ||
| optional Status status = 2; | ||
| optional string suspension_reason = 3; | ||
| optional OnDemandStatus ondemand_status = 4; | ||
| } | ||
|
|
||
| message UpsertAccountStatusResponse { | ||
| // True if a new record was created or an existing record was modified. | ||
| // False if the record already existed with identical field values. | ||
| bool updated = 1; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request duplicates entity fields instead of embedding message
Medium Severity
UpsertAccountStatusRequestduplicates every field fromAccountStatus(same types, tags, and optionality) instead of embeddingAccountStatusas a nested message — the pattern already used byGetAccountStatusResponse. IfAccountStatusgains a new field in the future, it would need to be manually added to this request message as well, risking silent data loss on upserts when the two definitions fall out of sync.Reviewed by Cursor Bugbot for commit 41ca379. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's okay, we don't want the caller to need to know the shape of the account status proto