Skip to content

feat(trace-item-values): Add counts to response #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmak merged 1 commit into from
May 22, 2026
+4 −1
Merged

feat(trace-item-values): Add counts to response #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ message TraceItemAttributeValuesRequest {
message TraceItemAttributeValuesResponse {
// all the values that matched the criteria specified in the request
repeated string values = 1;
repeated int64 counts = 3;

// page token for the next page of results
PageToken page_token = 6;
Expand Down
2 changes: 2 additions & 0 deletions rust/src/sentry_protos.snuba.v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1738,6 +1738,8 @@ pub struct TraceItemAttributeValuesResponse {
/// all the values that matched the criteria specified in the request
#[prost(string, repeated, tag = "1")]
pub values: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
#[prost(int64, repeated, tag = "3")]
pub counts: ::prost::alloc::vec::Vec<i64>,
/// page token for the next page of results
#[prost(message, optional, tag = "6")]
pub page_token: ::core::option::Option<PageToken>,
Expand Down
Loading