chore: using the param instead of calling a function#1224
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| logger.info(`Spotlight listening on ${info.port}`); | ||
| if (basePath) { | ||
| logSpotlightUrl(realPort); | ||
| logSpotlightUrl(info.port); |
There was a problem hiding this comment.
Dynamic port logging may show configured port instead of actual
When using port 0 for dynamic assignment (default for spotlight run), the old code explicitly retrieved the actual bound port via server.address() and stored it in a variable named realPort. The new code uses info.port from the callback parameter. If @hono/node-server passes back the configured port (0) rather than the actual bound port from AddressInfo, the log messages "Spotlight listening on 0" and "Open http://localhost:0 to see the Spotlight UI" would be displayed, which are incorrect and unusable. The explicit realPort naming in the original code suggests this distinction was intentional.
There was a problem hiding this comment.
I checked, its working with dynamic port
2 participants
No description provided.