Relationship config key doesn't seem to get used when saving a model

[WimWidgets]

The relationship config property key, to convert property names, only seems to work for incoming data and not for outgoing data (saving). I haven't experienced this issue with the similar attribute config property serializedName.

For example converting between camel case and dasherized.

@JsonApiModelConfig({type: 'endpoints/things'})
export class Thing extends JsonApiModel {

    @BelongsTo({key: 'foo-bar'})
    fooBar: FooBar;
}

@JsonApiModelConfig({type: 'endpoints/foo-bars'})
export class FooBar extends JsonApiModel { }

For every retrieved Thing the fooBar property is properly set by the foo-bar property coming from the API. Saving a new Thing with a set fooBar property sends this property as fooBar to the API instead of foo-bar.

Payload to the server

{
  "data": {
    "relationships": {
      "fooBar": {
        "data": {
          "type": "endpoints/foo-bars",
          "id": "1"
        }
      }
    },
    "type": "endpoints/things",
    "attributes": {}
  }
}

Is this a bug or am I missing something?

[WimWidgets]

I guess the problem is in the following lines:

angular2-jsonapi/src/services/json-api-datastore.service.ts

Line 226 in a736c0f

relationships[key] = {

angular2-jsonapi/src/services/json-api-datastore.service.ts

Line 237 in a736c0f

relationships[key] = {

Where the key is the literal property name of the model, instead of the key from the relationship config.

I have no idea how to get the config key to fix this.

[hpawe01]

It looks like a bug. For a possible solution you could have a look here:

angular2-jsonapi/src/models/json-api.model.ts

Line 162 in a736c0f

const belongsTo: any = Reflect.getMetadata('BelongsTo', this);

The key is mapped to relationship:

angular2-jsonapi/src/decorators/belongs-to.decorator.ts

Line 7 in a736c0f

relationship: config.key || propertyName

So, a possible solution could look like (untested):

  protected getRelationships(data: any): any {
    let relationships: any;
    const belongsToAttributes: any[] = Reflect.getMetadata('BelongsTo', data); // <---

    for (const key in data) {
      if (data.hasOwnProperty(key)) {
        if (data[key] instanceof JsonApiModel) {
          relationships = relationships || {};

          if (data[key].id) {
            const belongsToAttribute = belongsToAttributes.find((config) => config.propertyName === key); // <--
            const relationshipKey = (belongsToAttribute && belongsToAttribute.relationship) || key;
            relationships[relationshipKey] = {
              data: this.buildSingleRelationshipData(data[key])
            };
          }
...