Adds authentication type to integration sessions

Introduces a `type` property to authentication session and token information objects.

*   Sets the type to 'pat' for self-managed GitHub and GitLab integrations, indicating a Personal Access Token.
*   Initializes the type as `undefined` for built-in sessions and GitKraken tokens where a specific method isn't specified by the provider.
*   Ensures the `type` property is propagated and handled correctly across integration authentication flows and error reporting.

(#4880, #4896)

Author: sergeibbb

src/plus/gk/serverConnection.ts

@@ -270,6 +270,7 @@ export class ServerConnection implements Disposable {
 
 		const gitkrakenTokenInfo: TokenInfo<'gitkraken'> = toTokenInfo('gitkraken', token, {
 			cloud: true,
+			type: undefined,
 			scopes: undefined,
 		});
 

src/plus/gk/utils/-webview/integrationAuthentication.utils.ts

@@ -47,6 +47,7 @@ export const getBuiltInIntegrationSession = sequentialize(
 					return {
 						...session,
 						cloud: false,
+						type: undefined,
 						domain: descriptor.domain,
 					};
 				} catch (ex) {

src/plus/integrations/authentication/configuredIntegrationService.ts

@@ -13,14 +13,19 @@ import { getBuiltInIntegrationSession } from '../../gk/utils/-webview/integratio
 import { providersMetadata } from '../providers/models.js';
 import { isGitSelfManagedHostIntegrationId } from '../utils/-webview/integration.utils.js';
 import type { IntegrationAuthenticationSessionDescriptor } from './integrationAuthenticationProvider.js';
-import type { ConfiguredIntegrationDescriptor, ProviderAuthenticationSession } from './models.js';
+import type {
+	CloudIntegrationAuthType,
+	ConfiguredIntegrationDescriptor,
+	ProviderAuthenticationSession,
+} from './models.js';
 
 interface StoredSession {
 	id: string;
 	accessToken: string;
 	account?: { label?: string; displayName?: string; id: string };
 	scopes: string[];
 	cloud?: boolean;
+	type: CloudIntegrationAuthType | undefined;
 	expiresAt?: string;
 	domain?: string;
 	protocol?: string;
@@ -431,5 +436,6 @@ function convertStoredSessionToSession(
 		expiresAt: storedSession.expiresAt ? new Date(storedSession.expiresAt) : undefined,
 		domain: storedSession.domain ?? descriptor.domain,
 		protocol: storedSession.protocol,
+		type: storedSession.type,
 	};
 }

src/plus/integrations/authentication/github.ts

@@ -123,6 +123,7 @@ export class GitHubEnterpriseAuthenticationProvider extends LocalIntegrationAuth
 				label: '',
 			},
 			cloud: false,
+			type: 'pat',
 			domain: descriptor.domain,
 		};
 	}

src/plus/integrations/authentication/gitlab.ts

@@ -88,6 +88,7 @@ export class GitLabLocalAuthenticationProvider extends LocalIntegrationAuthentic
 				label: '',
 			},
 			cloud: false,
+			type: 'pat',
 			domain: descriptor.domain,
 		};
 	}

src/plus/integrations/authentication/integrationAuthenticationProvider.ts

@@ -298,6 +298,7 @@ export abstract class CloudIntegrationAuthenticationProvider<
 				label: '',
 			},
 			cloud: true,
+			type: session.type,
 			expiresAt: new Date(session.expiresIn * 1000 + Date.now()),
 			// Note: do not use the session's domain, because the format is different than in our model
 			domain: descriptor.domain,

src/plus/integrations/authentication/models.ts

@@ -12,6 +12,7 @@ import { configuration } from '../../../system/-webview/configuration.js';
 
 export interface ProviderAuthenticationSession extends AuthenticationSession {
 	readonly cloud: boolean;
+	readonly type: CloudIntegrationAuthType | undefined;
 	readonly expiresAt?: Date;
 	readonly domain: string;
 	readonly protocol?: string;
@@ -26,7 +27,7 @@ export interface TokenInfo<T extends IntegrationIds | 'gitkraken' = IntegrationI
 	 */
 	readonly microHash: string | undefined;
 	readonly cloud: boolean;
-	readonly type?: CloudIntegrationAuthType;
+	readonly type: CloudIntegrationAuthType | undefined;
 	readonly scopes: readonly string[] | undefined;
 	readonly expiresAt?: Date;
 }
@@ -38,12 +39,13 @@ export interface TokenWithInfo<T extends IntegrationIds = IntegrationIds> extend
 export function toTokenInfo<T extends IntegrationIds | 'gitkraken'>(
 	providerId: T,
 	accessToken: string | undefined,
-	info: { cloud: boolean; scopes?: readonly string[]; expiresAt?: Date },
+	info: { cloud: boolean; type: CloudIntegrationAuthType | undefined; scopes?: readonly string[]; expiresAt?: Date },
 ): TokenInfo<T> {
 	return {
 		providerId: providerId,
 		microHash: microhash(accessToken),
 		cloud: info.cloud,
+		type: info.type,
 		scopes: info.scopes,
 		expiresAt: info.expiresAt,
 	};

src/plus/integrations/providers/github/githubGitProvider.ts

@@ -1118,11 +1118,13 @@ export class GitHubGitProvider implements GitProvider, Disposable {
 							}
 						}
 						throw new AuthenticationError(
+							// scopes and other fields are undefined here because the token has not been issues:
 							{
 								providerId: this.authenticationProviderId,
 								microHash: undefined,
 								cloud: false,
-								scopes: undefined, // scopes are undefined because the token has not been issues
+								type: undefined,
+								scopes: undefined,
 							},
 							AuthenticationErrorReason.UserDidNotConsent,
 						);
@@ -1131,11 +1133,13 @@ export class GitHubGitProvider implements GitProvider, Disposable {
 					Logger.error(ex);
 					debugger;
 					throw new AuthenticationError(
+						// scopes and other fields are undefined here because the token has not been issues:
 						{
 							providerId: this.authenticationProviderId,
 							microHash: undefined,
 							cloud: false,
-							scopes: undefined, // scopes are undefined because the token has not been issues
+							type: undefined,
+							scopes: undefined,
 						},
 						undefined,
 						ex,