Merge b8026f9 into 320baae

Author: Copilot

.github/agents/pr-agent.md

@@ -176,6 +176,7 @@ Agent 禁止的事项（严格）：
 ## 风格与质量要求
 - C 代码：使用 `make format` 格式化（底层是 `clang-format`，style 定义在 `variables.mk` 的 `STYLE` 变量中）；
 - Go 代码：使用 `gofmt`/`goimports` 格式化，遵守 `.golangci.yml` 中的 lint 规则；
+- **golangci-lint 验证（必需）**：所有提交的 Go 代码必须通过 `golangci-lint` 检查。Agent 在提交 PR 前，必须运行 `golangci-lint run ./...`（使用仓库根目录的 `.golangci.yml` 配置），并确保无新增 lint 错误。CI 中使用 golangci-lint v2.1（配置版本 `version: 2`），本地安装命令：`go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6`；
 - 小步提交、单一目的 PR、清晰的 PR 描述；
 - 所有 PR 中若有未解决的集成测试限制，必须在 PR 描述中注明并提供复现步骤或需要的维护者权限/环境。
 

internal/probe/gotls/config.go

@@ -274,6 +274,12 @@ func (c *Config) validateCaptureMode() error {
 		if c.PcapFile == "" {
 			return fmt.Errorf("pcap mode requires PcapFile to be set")
 		}
+
+		// Auto-detect an active network interface when none is specified.
+		// On Android emulators wlan0 may exist but have no addresses;
+		// networking may go through eth0 or another interface instead.
+		c.setDefaultIfname()
+
 		if c.Ifname == "" {
 			return fmt.Errorf("pcap mode requires Ifname to be set")
 		}

internal/probe/gotls/config_iface.go

@@ -0,0 +1,85 @@
+// Copyright 2022 CFC4N <cfc4n.cs@gmail.com>. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package gotls
+
+import "net"
+
+// ifaceHasAddr returns true when the named interface exists, is up, and has at
+// least one address.
+func ifaceHasAddr(name string) bool {
+	iface, err := net.InterfaceByName(name)
+	if err != nil {
+		return false
+	}
+	if iface.Flags&net.FlagUp == 0 {
+		return false
+	}
+	addrs, err := iface.Addrs()
+	if err != nil {
+		return false
+	}
+	return len(addrs) > 0
+}
+
+// firstUpNonLoopbackInterface walks all network interfaces and returns the
+// name of the first non-loopback interface that is up and has an address.
+// Note: this is not necessarily the default-route interface; it may return
+// virtual bridges (e.g. docker0) before the real egress interface.
+func firstUpNonLoopbackInterface() string {
+	ifaces, err := net.Interfaces()
+	if err != nil {
+		return ""
+	}
+	for _, iface := range ifaces {
+		if iface.Flags&net.FlagLoopback != 0 {
+			continue
+		}
+		if iface.Flags&net.FlagUp == 0 {
+			continue
+		}
+		addrs, err := iface.Addrs()
+		if err != nil || len(addrs) == 0 {
+			continue
+		}
+		return iface.Name
+	}
+	return ""
+}
+
+// setDefaultIfname detects an active network interface when Ifname is empty.
+// On real devices wlan0 is common, but in emulators networking may use eth0
+// or another interface. This function tries to find an interface that is up
+// and has at least one IP address.
+func (c *Config) setDefaultIfname() {
+	if c.Ifname != "" {
+		return
+	}
+
+	// Try the common default first.
+	if ifaceHasAddr("wlan0") {
+		c.Ifname = "wlan0"
+		return
+	}
+
+	// Fallback: iterate all interfaces looking for one that is up and has an
+	// address, skipping loopback.
+	if name := firstUpNonLoopbackInterface(); name != "" {
+		c.Ifname = name
+		return
+	}
+
+	// Last resort: keep the historical default so the error message is clear.
+	c.Ifname = "wlan0"
+}

internal/probe/gotls/config_iface_test.go

@@ -0,0 +1,86 @@
+// Copyright 2022 CFC4N <cfc4n.cs@gmail.com>. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package gotls
+
+import (
+	"net"
+	"testing"
+)
+
+func TestIfaceHasAddr_Loopback(t *testing.T) {
+	// The loopback interface (lo) should always be present and have an address
+	// on Linux. On non-Linux or unusual environments, skip.
+	iface, err := net.InterfaceByName("lo")
+	if err != nil {
+		t.Skip("loopback interface 'lo' not available on this host")
+	}
+	if iface.Flags&net.FlagUp == 0 {
+		t.Skip("loopback interface 'lo' is not UP")
+	}
+	if !ifaceHasAddr("lo") {
+		t.Error("ifaceHasAddr returned false for loopback interface 'lo' which is UP")
+	}
+}
+
+func TestIfaceHasAddr_NonExistent(t *testing.T) {
+	// A completely made-up interface name should return false.
+	if ifaceHasAddr("nonexistent_iface_xyz") {
+		t.Error("ifaceHasAddr returned true for a non-existent interface")
+	}
+}
+
+func TestFirstUpNonLoopbackInterface(t *testing.T) {
+	name := firstUpNonLoopbackInterface()
+	if name == "" {
+		t.Skip("no active non-loopback interface found on this host")
+	}
+
+	// The returned interface must actually be up and have addresses.
+	iface, err := net.InterfaceByName(name)
+	if err != nil {
+		t.Fatalf("firstUpNonLoopbackInterface returned %q but InterfaceByName failed: %v", name, err)
+	}
+	if iface.Flags&net.FlagUp == 0 {
+		t.Errorf("firstUpNonLoopbackInterface returned %q which is not UP", name)
+	}
+	if iface.Flags&net.FlagLoopback != 0 {
+		t.Errorf("firstUpNonLoopbackInterface returned loopback interface %q", name)
+	}
+	addrs, err := iface.Addrs()
+	if err != nil {
+		t.Fatalf("cannot get addresses for %q: %v", name, err)
+	}
+	if len(addrs) == 0 {
+		t.Errorf("firstUpNonLoopbackInterface returned %q which has no addresses", name)
+	}
+}
+
+func TestSetDefaultIfname(t *testing.T) {
+	// When Ifname is already set, setDefaultIfname should not change it.
+	c := NewConfig()
+	c.Ifname = "eth99"
+	c.setDefaultIfname()
+	if c.Ifname != "eth99" {
+		t.Errorf("setDefaultIfname changed pre-set Ifname from 'eth99' to %q", c.Ifname)
+	}
+
+	// When Ifname is empty, setDefaultIfname should set it to something non-empty.
+	c2 := NewConfig()
+	c2.Ifname = ""
+	c2.setDefaultIfname()
+	if c2.Ifname == "" {
+		t.Error("setDefaultIfname left Ifname empty")
+	}
+}

internal/probe/openssl/config_ecandroid.go

@@ -104,11 +104,30 @@ func detectAndroidVersion() (string, error) {
 	return "", fmt.Errorf("android version not found in build.prop")
 }
 
-// Android-specific default interface
+// Android-specific default interface.
+// On real devices wlan0 is common, but in emulators networking may use eth0
+// or another interface. This function tries to find an interface that is up
+// and has at least one IP address.
 func (c *Config) setDefaultIfname() {
-	if c.Ifname == "" {
+	if c.Ifname != "" {
+		return
+	}
+
+	// Try the common Android default first.
+	if ifaceHasAddr(DefaultIfname) {
 		c.Ifname = DefaultIfname
+		return
 	}
+
+	// Fallback: iterate all interfaces looking for one that is up and has an
+	// address, skipping loopback.
+	if name := firstUpNonLoopbackInterface(); name != "" {
+		c.Ifname = name
+		return
+	}
+
+	// Last resort: keep the historical default so the error message is clear.
+	c.Ifname = DefaultIfname
 }
 
 // validateCgroupPath is a no-op on Android since cgroup filtering is not supported.

internal/probe/openssl/config_iface.go

@@ -0,0 +1,59 @@
+// Copyright 2022 CFC4N <cfc4n.cs@gmail.com>. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package openssl
+
+import "net"
+
+// ifaceHasAddr returns true when the named interface exists, is up, and has at
+// least one address.
+func ifaceHasAddr(name string) bool {
+	iface, err := net.InterfaceByName(name)
+	if err != nil {
+		return false
+	}
+	if iface.Flags&net.FlagUp == 0 {
+		return false
+	}
+	addrs, err := iface.Addrs()
+	if err != nil {
+		return false
+	}
+	return len(addrs) > 0
+}
+
+// firstUpNonLoopbackInterface walks all network interfaces and returns the
+// name of the first non-loopback interface that is up and has an address.
+// Note: this is not necessarily the default-route interface; it may return
+// virtual bridges (e.g. docker0) before the real egress interface.
+func firstUpNonLoopbackInterface() string {
+	ifaces, err := net.Interfaces()
+	if err != nil {
+		return ""
+	}
+	for _, iface := range ifaces {
+		if iface.Flags&net.FlagLoopback != 0 {
+			continue
+		}
+		if iface.Flags&net.FlagUp == 0 {
+			continue
+		}
+		addrs, err := iface.Addrs()
+		if err != nil || len(addrs) == 0 {
+			continue
+		}
+		return iface.Name
+	}
+	return ""
+}

internal/probe/openssl/config_iface_test.go

@@ -0,0 +1,68 @@
+// Copyright 2022 CFC4N <cfc4n.cs@gmail.com>. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package openssl
+
+import (
+	"net"
+	"testing"
+)
+
+func TestIfaceHasAddr_Loopback(t *testing.T) {
+	// The loopback interface (lo) should always be present and have an address
+	// on Linux. On non-Linux or unusual environments, skip.
+	iface, err := net.InterfaceByName("lo")
+	if err != nil {
+		t.Skip("loopback interface 'lo' not available on this host")
+	}
+	if iface.Flags&net.FlagUp == 0 {
+		t.Skip("loopback interface 'lo' is not UP")
+	}
+	if !ifaceHasAddr("lo") {
+		t.Error("ifaceHasAddr returned false for loopback interface 'lo' which is UP")
+	}
+}
+
+func TestIfaceHasAddr_NonExistent(t *testing.T) {
+	// A completely made-up interface name should return false.
+	if ifaceHasAddr("nonexistent_iface_xyz") {
+		t.Error("ifaceHasAddr returned true for a non-existent interface")
+	}
+}
+
+func TestFirstUpNonLoopbackInterface(t *testing.T) {
+	name := firstUpNonLoopbackInterface()
+	if name == "" {
+		t.Skip("no active non-loopback interface found on this host")
+	}
+
+	// The returned interface must actually be up and have addresses.
+	iface, err := net.InterfaceByName(name)
+	if err != nil {
+		t.Fatalf("firstUpNonLoopbackInterface returned %q but InterfaceByName failed: %v", name, err)
+	}
+	if iface.Flags&net.FlagUp == 0 {
+		t.Errorf("firstUpNonLoopbackInterface returned %q which is not UP", name)
+	}
+	if iface.Flags&net.FlagLoopback != 0 {
+		t.Errorf("firstUpNonLoopbackInterface returned loopback interface %q", name)
+	}
+	addrs, err := iface.Addrs()
+	if err != nil {
+		t.Fatalf("cannot get addresses for %q: %v", name, err)
+	}
+	if len(addrs) == 0 {
+		t.Errorf("firstUpNonLoopbackInterface returned %q which has no addresses", name)
+	}
+}

internal/probe/openssl/config_linux.go

@@ -103,6 +103,19 @@ func (c *Config) setDefaultIfname() {
 		return
 	}
 
+	// Try the historical default first.
+	if ifaceHasAddr("wlan0") {
+		c.Ifname = "wlan0"
+		return
+	}
+
+	// Fallback: iterate all interfaces looking for one that is up and has an
+	// address, skipping loopback.
+	if name := firstUpNonLoopbackInterface(); name != "" {
+		c.Ifname = name
+		return
+	}
+
 	c.Ifname = "wlan0"
 }