fix: #14 to support some arch linux #15
Conversation
cfc4n
left a comment
cfc4n
left a comment
There was a problem hiding this comment.
as codeview comment. please reupdate, and keep one git commit with git reset --soft command. thanks.
| if e != nil { | ||
| prefix = OTHERS_BINARY_PREFIX | ||
| } | ||
| this.Openssl = prefix + "/libssl.so.1.1" |
There was a problem hiding this comment.
please use filepath.Join() to concatenate strings.
There was a problem hiding this comment.
of course, I prefer to use git rebase -i HEAD~3 could I do it that way ?
| default: | ||
| //如果没找到 | ||
| binaryPath = "/lib/x86_64-linux-gnu/libgnutls.so.30" | ||
| binaryPath = prefix + "/libgnutls.so.30" |
There was a problem hiding this comment.
keep origin value due binaryPath is certain from config_* struct.
There was a problem hiding this comment.
keep origin value due
binaryPathis certain fromconfig_*struct.
Sorry I missed to understand this comment, why the logic should change here?
| default: | ||
| //如果没找到 | ||
| binaryPath = "/lib/x86_64-linux-gnu/libgnutls.so.30" | ||
| binaryPath = filepath.Join(prefix, "libgnutls.so.30") |
There was a problem hiding this comment.
please rollback this code block. search .so path must be finished by config_ . probe_module do not choose so_ ,just use a default value.
|
Rollback and fixed |
|
LGTM, thanks. |
2 participants
fix: #14 by changing the root dir.