fix: call config.onError if present if isReadyToPay throws#73
Merged
socsieng merged 2 commits intogoogle-pay:mainfrom Feb 17, 2021
Merged
fix: call config.onError if present if isReadyToPay throws#73socsieng merged 2 commits intogoogle-pay:mainfrom
socsieng merged 2 commits intogoogle-pay:mainfrom
Conversation
Collaborator
|
Thanks for the PR. Can you include repro steps you used to trigger the error? |
Contributor
Author
|
Sure!
|
This was referenced Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the
isReadyToPaythrows when setting up the Google Pay button, theonErrorcallback is not called and the error is printed out in console throughconsole.errorinstead. This PR adds support for triggering theonErrorcallback if present and otherwise fallback to the existing behaviour.