feat: add error types for better validation#166
Merged
bormanp merged 2 commits intogoogle:masterfrom Aug 6, 2024
Merged
Conversation
bormanp
suggested changes
Aug 3, 2024
Contributor
bormanp
left a comment
There was a problem hiding this comment.
I understand what you are trying to do and overall it seems like a worthy idea.
Given the number of packages that include this package I am rather paranoid about any functional change. I don't mind the custom error becoming public as that is an addition and changes nothing.
Contributor
Author
|
Hi @bormanp , I really appreciate your review and valid suggestions. I've removed some changes that were added unintentionally by my code formatter in my code editor. Additionally I've sightly modified the approach with |
bormanp
approved these changes
Aug 5, 2024
tkarrass
pushed a commit
to tkarrass/uuid
that referenced
this pull request
Sep 11, 2024
* feat: add error types * fix: broken backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves error handling by adding specific error types and ensuring compatibility with
errors.Isfor better validation. The changes include:ErrInvalidUUIDFormatErrInvalidURNPrefixErrInvalidBracketedFormatErrInvalidLengthParse,ParseBytes, andValidatefunctions to wrap errors with additional context usingfmt.Errorfand%w.IsInvalidLengthErrorfunction.