Skip to content

Commit 2fad3d5

Browse files
chore: update README and system test for node20 (#919)
* chore: update README and system test for node20 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 2a94145 commit 2fad3d5

3 files changed

Lines changed: 22 additions & 19 deletions

File tree

handwritten/devtools-cloudprofiler/.readme-partials.yaml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,14 @@ body: |-
22
33
### Prerequisites
44
5-
1. Your application will need to be using Node.js 10.4.1 or greater or Node.js
6-
12. The profiler will not be enabled when using earlier versions of 10 because
7-
versions of Node.js 10 prior to 10.4.1 are impacted by
8-
[this](https://bugs.chromium.org/p/chromium/issues/detail?id=847863) issue,
9-
which can cause garbage collection to take several minutes when heap profiling
10-
is enabled.
5+
1. Your application will need to be using Node.js version between 14 and 20.
116
127
1. `@google-cloud/profiler` depends on the
138
[`pprof`](https://www.npmjs.com/package/pprof) module, a module with a native
149
component that is used to collect profiles with v8's CPU and Heap profilers.
1510
You may need to install additional dependencies to build the `pprof` module.
1611
* For Linux: `pprof` has prebuilt binaries available for Linux and Alpine
17-
Linux for Node 10 and 12. No additional dependencies are required.
12+
Linux for Node 14 and 16. No additional dependencies are required.
1813
* For other environments: when using `@google-cloud/profiler` on environments
1914
that `pprof` does not have prebuilt binaries for, the module
2015
[`node-gyp`](https://www.npmjs.com/package/node-gyp) will be used to
@@ -142,10 +137,10 @@ body: |-
142137
143138
```json
144139
"engines": {
145-
"node": ">=10.4.1"
140+
"node": ">=14.0.0"
146141
}
147142
```
148-
The above snippet will ensure that you're using 10.4.1 or greater.
143+
The above snippet will ensure that you're using 14.0.0 or greater.
149144
150145
Deploy your application to App Engine Flexible environment as usual.
151146
@@ -277,4 +272,4 @@ body: |-
277272
private_key: 'private_key'
278273
}
279274
});
280-
```
275+
```

handwritten/devtools-cloudprofiler/README.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,19 +55,14 @@ npm install @google-cloud/profiler
5555

5656
### Prerequisites
5757

58-
1. Your application will need to be using Node.js 10.4.1 or greater or Node.js
59-
12. The profiler will not be enabled when using earlier versions of 10 because
60-
versions of Node.js 10 prior to 10.4.1 are impacted by
61-
[this](https://bugs.chromium.org/p/chromium/issues/detail?id=847863) issue,
62-
which can cause garbage collection to take several minutes when heap profiling
63-
is enabled.
58+
1. Your application will need to be using Node.js version between 14 and 20.
6459

6560
1. `@google-cloud/profiler` depends on the
6661
[`pprof`](https://www.npmjs.com/package/pprof) module, a module with a native
6762
component that is used to collect profiles with v8's CPU and Heap profilers.
6863
You may need to install additional dependencies to build the `pprof` module.
6964
* For Linux: `pprof` has prebuilt binaries available for Linux and Alpine
70-
Linux for Node 10 and 12. No additional dependencies are required.
65+
Linux for Node 14 and 16. No additional dependencies are required.
7166
* For other environments: when using `@google-cloud/profiler` on environments
7267
that `pprof` does not have prebuilt binaries for, the module
7368
[`node-gyp`](https://www.npmjs.com/package/node-gyp) will be used to
@@ -195,10 +190,10 @@ the following to your `package.json`:
195190

196191
```json
197192
"engines": {
198-
"node": ">=10.4.1"
193+
"node": ">=14.0.0"
199194
}
200195
```
201-
The above snippet will ensure that you're using 10.4.1 or greater.
196+
The above snippet will ensure that you're using 14.0.0 or greater.
202197

203198
Deploy your application to App Engine Flexible environment as usual.
204199

handwritten/devtools-cloudprofiler/system-test/integration_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,19 @@ func TestAgentIntegration(t *testing.T) {
300300
timeout: gceTestTimeout,
301301
benchDuration: gceBenchDuration,
302302
},
303+
{
304+
InstanceConfig: proftest.InstanceConfig{
305+
ProjectID: projectID,
306+
Zone: zone,
307+
Name: fmt.Sprintf("profiler-test-node20-%s", runID),
308+
MachineType: "n1-standard-1",
309+
},
310+
name: fmt.Sprintf("profiler-test-node20-%s-gce", runID),
311+
wantProfiles: wantProfiles,
312+
nodeVersion: "20",
313+
timeout: gceTestTimeout,
314+
benchDuration: gceBenchDuration,
315+
},
303316
}
304317

305318
if *runBackoffTest {

0 commit comments

Comments
 (0)