Fixing use of Iterator in storage system tests.

Author: dhermes

system_tests/storage.py

@@ -257,13 +257,20 @@ def test_paginate_files(self):
         truncation_size = 1
         count = len(self.FILENAMES) - truncation_size
         iterator = self.bucket.list_blobs(max_results=count)
-        iterator.update_page()
-        blobs = list(iterator.page)
+        page_iter = iterator.pages
+
+        page1 = six.next(page_iter)
+        blobs = list(page1)
         self.assertEqual(len(blobs), count)
         self.assertIsNotNone(iterator.next_page_token)
-
-        iterator.update_page()
-        last_blobs = list(iterator.page)
+        # Technically the iterator is exhausted.
+        self.assertEqual(iterator.num_results, iterator.max_results)
+        # But we modify the iterator to continue paging after
+        # articially stopping after ``count`` items.
+        iterator.max_results = None
+
+        page2 = six.next(page_iter)
+        last_blobs = list(page2)
         self.assertEqual(len(last_blobs), truncation_size)
 
 
@@ -301,17 +308,17 @@ def tearDownClass(cls):
     @RetryErrors(unittest.TestCase.failureException)
     def test_root_level_w_delimiter(self):
         iterator = self.bucket.list_blobs(delimiter='/')
-        iterator.update_page()
-        blobs = list(iterator.page)
+        page = six.next(iterator.pages)
+        blobs = list(page)
         self.assertEqual([blob.name for blob in blobs], ['file01.txt'])
         self.assertIsNone(iterator.next_page_token)
         self.assertEqual(iterator.prefixes, set(['parent/']))
 
     @RetryErrors(unittest.TestCase.failureException)
     def test_first_level(self):
         iterator = self.bucket.list_blobs(delimiter='/', prefix='parent/')
-        iterator.update_page()
-        blobs = list(iterator.page)
+        page = six.next(iterator.pages)
+        blobs = list(page)
         self.assertEqual([blob.name for blob in blobs], ['parent/file11.txt'])
         self.assertIsNone(iterator.next_page_token)
         self.assertEqual(iterator.prefixes, set(['parent/child/']))
@@ -325,8 +332,8 @@ def test_second_level(self):
 
         iterator = self.bucket.list_blobs(delimiter='/',
                                           prefix='parent/child/')
-        iterator.update_page()
-        blobs = list(iterator.page)
+        page = six.next(iterator.pages)
+        blobs = list(page)
         self.assertEqual([blob.name for blob in blobs],
                          expected_names)
         self.assertIsNone(iterator.next_page_token)
@@ -341,8 +348,8 @@ def test_third_level(self):
         # Exercise a layer deeper to illustrate this.
         iterator = self.bucket.list_blobs(delimiter='/',
                                           prefix='parent/child/grand/')
-        iterator.update_page()
-        blobs = list(iterator.page)
+        page = six.next(iterator.pages)
+        blobs = list(page)
         self.assertEqual([blob.name for blob in blobs],
                          ['parent/child/grand/file31.txt'])
         self.assertIsNone(iterator.next_page_token)