Skip to content

Commit 303f2a8

Browse files
committed
Merge pull request #1613 from tseaver/logging-system_test-metric_update
Add system test for 'Metric.update'.
2 parents 4b88a63 + e3d1783 commit 303f2a8

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

system_tests/logging_.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,3 +106,20 @@ def test_reload_metric(self):
106106
metric.reload()
107107
self.assertEqual(metric.filter_, DEFAULT_FILTER)
108108
self.assertEqual(metric.description, DEFAULT_DESCRIPTION)
109+
110+
def test_update_metric(self):
111+
NEW_FILTER = 'logName:other'
112+
NEW_DESCRIPTION = 'updated'
113+
metric = Config.CLIENT.metric(
114+
DEFAULT_METRIC_NAME, DEFAULT_FILTER, DEFAULT_DESCRIPTION)
115+
self.assertFalse(metric.exists())
116+
metric.create()
117+
self.to_delete.append(metric)
118+
metric.filter_ = NEW_FILTER
119+
metric.description = NEW_DESCRIPTION
120+
metric.update()
121+
after_metrics, _ = Config.CLIENT.list_metrics()
122+
after_info = dict((metric.name, metric) for metric in after_metrics)
123+
after = after_info[DEFAULT_METRIC_NAME]
124+
self.assertEqual(after.filter_, NEW_FILTER)
125+
self.assertEqual(after.description, NEW_DESCRIPTION)

0 commit comments

Comments
 (0)