Skip to content

Commit 3dfea5c

Browse files
committed
Using client's credentials in error reporting (instead of connection).
1 parent afef191 commit 3dfea5c

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

error_reporting/google/cloud/error_reporting/_gax.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def make_report_error_api(client):
3434
:returns: An Error Reporting API instance.
3535
"""
3636
channel = make_secure_channel(
37-
client._connection.credentials,
37+
client._credentials,
3838
DEFAULT_USER_AGENT,
3939
report_errors_service_client.ReportErrorsServiceClient.SERVICE_ADDRESS)
4040
gax_client = report_errors_service_client.ReportErrorsServiceClient(

error_reporting/unit_tests/test__gax.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,11 @@ class Test_make_report_error_api(unittest.TestCase):
2222
def test_make_report_error_api(self):
2323
from google.cloud.error_reporting._gax import make_report_error_api
2424

25-
client = mock.Mock()
26-
client.project = mock.Mock()
25+
client = mock.Mock(
26+
_credentials=mock.sentinel.credentials,
27+
project='prahj-ekt',
28+
spec=['project', '_credentials'],
29+
)
2730
report_error_client = make_report_error_api(client)
2831
self.assertEqual(report_error_client._project, client.project)
2932

0 commit comments

Comments
 (0)