Skip to content

Commit 4008775

Browse files
author
Aza Tulepbergenov
authored
fix: add missing metadata. (#1335)
* fix: add missing metadata. * chore: update dep. * chore: remove flaky setup.
1 parent d50d462 commit 4008775

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/_async_mixins.py.j2

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,12 @@
258258
client_info=DEFAULT_CLIENT_INFO,
259259
)
260260

261-
metadata = tuple(metadata)
261+
# Certain fields should be provided within the metadata header;
262+
# add these here.
263+
metadata = tuple(metadata) + (
264+
gapic_v1.routing_header.to_grpc_metadata(
265+
(("name", request.name),)),
266+
)
262267

263268
# Send the request.
264269
response = await rpc(

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/_mixins.py.j2

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,12 @@
256256
client_info=DEFAULT_CLIENT_INFO,
257257
)
258258

259-
metadata = tuple(metadata)
259+
# Certain fields should be provided within the metadata header;
260+
# add these here.
261+
metadata = tuple(metadata) + (
262+
gapic_v1.routing_header.to_grpc_metadata(
263+
(("name", request.name),)),
264+
)
260265

261266
# Send the request.
262267
response = rpc(

packages/gapic-generator/noxfile.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -347,16 +347,6 @@ def showcase_unit_alternative_templates(session):
347347
def showcase_unit_add_iam_methods(session):
348348
with showcase_library(session, other_opts=("add-iam-methods",)) as lib:
349349
session.chdir(lib)
350-
351-
# Unit tests are run twice with different dependencies.
352-
# 1. Run tests at lower bound of dependencies.
353-
session.install("nox")
354-
session.run("nox", "-s", "update_lower_bounds")
355-
session.install(".", "--force-reinstall", "-c", "constraints.txt")
356-
run_showcase_unit_tests(session, fail_under=0)
357-
358-
# 2. Run the tests again with latest version of dependencies.
359-
session.install(".", "--upgrade", "--force-reinstall")
360350
run_showcase_unit_tests(session, fail_under=100)
361351

362352

0 commit comments

Comments
 (0)