fix(resourcemanager): update test assertion and core version pin (#10095)

plamut · web-flow · commit 755eb36cf37f · 2020-01-10T17:57:24.000Z
* Adjust request params assertion in test (timeout)

* Bump pin for core dependency

This is to assure that Connection object from core supports
timeouts.
diff --git a/resource_manager/setup.py b/resource_manager/setup.py
@@ -29,7 +29,7 @@
 # 'Development Status :: 5 - Production/Stable'
 release_status = 'Development Status :: 3 - Alpha'
 dependencies = [
-    "google-cloud-core >= 1.0.3, < 2.0dev",
+    "google-cloud-core >= 1.1.0, < 2.0dev",
 ]
 extras = {
 }
diff --git a/resource_manager/tests/unit/test__http.py b/resource_manager/tests/unit/test__http.py
@@ -74,5 +74,9 @@ def test_extra_headers(self):
         }
         expected_uri = conn.build_api_url("/rainbow")
         http.request.assert_called_once_with(
-            data=req_data, headers=expected_headers, method="GET", url=expected_uri
+            data=req_data,
+            headers=expected_headers,
+            method="GET",
+            url=expected_uri,
+            timeout=None,
         )

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`# 'Development Status :: 5 - Production/Stable'`
`30`	`30`	`release_status = 'Development Status :: 3 - Alpha'`
`31`	`31`	`dependencies = [`
`32`		`- "google-cloud-core >= 1.0.3, < 2.0dev",`
	`32`	`+ "google-cloud-core >= 1.1.0, < 2.0dev",`
`33`	`33`	`]`
`34`	`34`	`extras = {`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,5 +74,9 @@ def test_extra_headers(self):`
`74`	`74`	`}`
`75`	`75`	`expected_uri = conn.build_api_url("/rainbow")`
`76`	`76`	`http.request.assert_called_once_with(`
`77`		`- data=req_data, headers=expected_headers, method="GET", url=expected_uri`
	`77`	`+ data=req_data,`
	`78`	`+ headers=expected_headers,`
	`79`	`+ method="GET",`
	`80`	`+ url=expected_uri,`
	`81`	`+ timeout=None,`
`78`	`82`	`)`