Skip to content

Commit 86acc4a

Browse files
committed
Merge pull request #563 from dhermes/storage-safe-teardown
Making sure delete does not fail in regression tests.
2 parents 927c534 + 0b90362 commit 86acc4a

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

regression/storage.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,20 @@ def setUpModule():
3939
SHARED_BUCKETS['test_bucket'] = connection.create_bucket(bucket_name)
4040

4141

42+
def safe_delete(bucket):
43+
for key in bucket:
44+
try:
45+
key.delete()
46+
except storage.exceptions.NotFound:
47+
print('Delete failed with 404: %r' % (key,))
48+
49+
# Passing force=False does not try to delete the contained files.
50+
bucket.delete(force=False)
51+
52+
4253
def tearDownModule():
4354
for bucket in SHARED_BUCKETS.values():
44-
# Passing force=True also deletes all files.
45-
bucket.delete(force=True)
55+
safe_delete(bucket)
4656

4757

4858
class TestStorage(unittest2.TestCase):

0 commit comments

Comments
 (0)