Skip to content

Commit 99616fa

Browse files
committed
Merge pull request #740 from dhermes/fix-725-regression-failure
Fixing regression failure introduced in #725.
2 parents 99af3ad + 145c53f commit 99616fa

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

regression/storage.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def test_large_file_write_from_stream(self):
119119

120120
file_data = self.FILES['big']
121121
with open(file_data['path'], 'rb') as file_obj:
122-
self.bucket.upload_file_object(file_obj, blob=blob)
122+
self.bucket.upload_file_object(file_obj, blob_name=blob.name)
123123
self.case_blobs_to_delete.append(blob)
124124

125125
blob._reload_properties() # force a reload
@@ -165,7 +165,7 @@ def test_direct_write_and_read_into_file(self):
165165

166166
def test_copy_existing_file(self):
167167
blob = self.bucket.upload_file(self.FILES['logo']['path'],
168-
blob='CloudLogo')
168+
blob_name='CloudLogo')
169169
self.case_blobs_to_delete.append(blob)
170170

171171
new_blob = self.bucket.copy_blob(blob, self.bucket, 'CloudLogoCopy')
@@ -190,7 +190,7 @@ def setUpClass(cls):
190190
blob.delete()
191191

192192
logo_path = cls.FILES['logo']['path']
193-
blob = cls.bucket.upload_file(logo_path, blob=cls.FILENAMES[0])
193+
blob = cls.bucket.upload_file(logo_path, blob_name=cls.FILENAMES[0])
194194
cls.suite_blobs_to_delete = [blob]
195195

196196
# Copy main blob onto remaining in FILENAMES.
@@ -241,7 +241,7 @@ def setUpClass(cls):
241241
blob.delete()
242242

243243
simple_path = cls.FILES['simple']['path']
244-
blob = cls.bucket.upload_file(simple_path, blob=cls.FILENAMES[0])
244+
blob = cls.bucket.upload_file(simple_path, blob_name=cls.FILENAMES[0])
245245
cls.suite_blobs_to_delete = [blob]
246246
for filename in cls.FILENAMES[1:]:
247247
new_blob = cls.bucket.copy_blob(blob, cls.bucket, filename)
@@ -336,4 +336,4 @@ def test_create_signed_delete_url(self):
336336
self.assertEqual(content, '')
337337

338338
# Check that the blob has actually been deleted.
339-
self.assertFalse(blob in self.bucket)
339+
self.assertFalse(blob.name in self.bucket)

0 commit comments

Comments
 (0)