chore: add ConfiguredSnippet.filename (#1523)

* chore: add ConfiguredSnippet.filename

* add inflection to dependency

* set upperbound on dependencies in setup.py

Author: dizcology

packages/gapic-generator/gapic/configurable_snippetgen/configured_snippet.py

@@ -14,6 +14,7 @@
 
 import dataclasses
 
+import inflection
 import libcst
 
 from gapic.configurable_snippetgen import snippet_config_language_pb2
@@ -58,8 +59,22 @@ def sample_function_name(self) -> str:
         """The sample function's name.
 
         For example:
-            "sample_create_custom_class_basic"
+            "sample_create_custom_class_Basic"
         """
         snippet_method_name = self.config.signature.snippet_method_name
         config_id = self.config.metadata.config_id
         return f"sample_{snippet_method_name}_{config_id}"
+
+    @property
+    def filename(self) -> str:
+        """The snippet's file name.
+
+        For example:
+            "speech_v1_generated_Adaptation_create_custom_class_Basic_async.py"
+        """
+        module_name = self.config.rpc.proto_package.split(".")[-1]
+        service_name = self.config.rpc.service_name
+        snake_case_rpc_name = inflection.underscore(self.config.rpc.rpc_name)
+        config_id = self.config.metadata.config_id
+        sync_or_async = "sync" if self.is_sync else "async"
+        return f"{module_name}_{self.api_version}_generated_{service_name}_{snake_case_rpc_name}_{config_id}_{sync_or_async}.py"

packages/gapic-generator/requirements.txt

@@ -10,4 +10,5 @@ setuptools==65.6.3
 grpc-google-iam-v1==0.12.4
 proto-plus==1.22.1
 pytest-asyncio==0.20.2
-libcst==0.4.9
+libcst==0.4.9
+inflection==0.5.1

packages/gapic-generator/setup.py

@@ -34,7 +34,8 @@
     "pypandoc >= 1.4",
     "PyYAML >= 5.1.1",
     "grpc-google-iam-v1 >= 0.12.4, < 1.0.0dev",
-    "libcst >= 0.4.9",
+    "libcst >= 0.4.9, < 1.0.0dev",
+    "inflection >= 0.5.1, < 1.0.0dev",
 ]
 
 package_root = os.path.abspath(os.path.dirname(__file__))

packages/gapic-generator/tests/unit/configurable_snippetgen/test_configured_snippet.py

@@ -76,36 +76,31 @@ def _make_configured_snippet(
     )
 
 
-def test_region_tag():
-    snippet = _make_configured_snippet(
+@pytest.fixture
+def snippet():
+    return _make_configured_snippet(
         SPEECH_V1_REQUEST_PATH,
         CONFIG_JSON_PATH,
         api_version="v1",
         is_sync=True)
 
+
+def test_region_tag(snippet):
     assert (
         snippet.region_tag
         == "speech_v1_config_Adaptation_CreateCustomClass_Basic_sync"
     )
 
 
-def test_sample_function_name():
-    snippet = _make_configured_snippet(
-        SPEECH_V1_REQUEST_PATH,
-        CONFIG_JSON_PATH,
-        api_version="v1",
-        is_sync=True)
-
+def test_sample_function_name(snippet):
     assert snippet.sample_function_name == "sample_create_custom_class_Basic"
 
 
-def test_code():
-    snippet = _make_configured_snippet(
-        SPEECH_V1_REQUEST_PATH,
-        CONFIG_JSON_PATH,
-        api_version="v1",
-        is_sync=True)
+def test_filename(snippet):
+    assert snippet.filename == "speech_v1_generated_Adaptation_create_custom_class_Basic_sync.py"
+
 
+def test_code(snippet):
     # https://github.com/googleapis/gapic-generator-python/issues/1522
     # Placeholder code.  We will gradually add to the ConfiguredSnippet class
     # until the generated code is the same as that of the golden file.