chore(tests): added missing test dependency (#387)

Author: daniel-sanche

packages/google-cloud-logging/.kokoro/environment_tests.sh

@@ -72,6 +72,7 @@ echo $ENVCTL_ID
 
 # Run the specified environment test
 set +e
+
 python3.6 -m nox --session "tests(language='python', platform='$ENVIRONMENT')"
 TEST_STATUS_CODE=$?
 

packages/google-cloud-logging/tests/environment/deployable/nodejs/Dockerfile

@@ -23,10 +23,15 @@ WORKDIR /usr/src/app
 COPY package*.json ./
 COPY app.js ./
 COPY tests.js ./
-# Assumption: local file is already built
+
+# Compile library
 COPY _library ./nodejs-logging
+WORKDIR nodejs-logging
+RUN npm install
+RUN npm run compile
 
-# Install test app's dependencies.
+# Install other dependencies
+WORKDIR /usr/src/app
 RUN npm install --production
 
 # Environment variable denoting whether to run an app server

packages/google-cloud-logging/tests/environment/deployable/python/requirements.txt

@@ -1,3 +1,4 @@
 flask==1.1.2
 google-cloud-pubsub==2.3.0
 click==7.1.2
+pytz==2021.1

packages/google-cloud-logging/tests/environment/envctl/env_scripts/nodejs/cloudrun.sh

@@ -68,26 +68,8 @@ verify() {
   set -e
 }
 
-build_node_container() {
-  export GCR_PATH=gcr.io/$PROJECT_ID/logging:$SERVICE_NAME
-  # copy super-repo into deployable dir
-  _env_tests_relative_path=${REPO_ROOT#"$SUPERREPO_ROOT/"}
-  _deployable_dir=$REPO_ROOT/deployable/$LANGUAGE
-
-  # copy over local copy of library
-  pushd $SUPERREPO_ROOT
-    tar -cvf $_deployable_dir/lib.tar --exclude node_modules --exclude env-tests-logging --exclude test --exclude system-test --exclude .nox --exclude samples --exclude docs .
-  popd
-  mkdir -p $_deployable_dir/$LIBRARY_NAME
-  tar -xvf $_deployable_dir/lib.tar --directory $_deployable_dir/$LIBRARY_NAME
-
-  # build container
-  docker build -t $GCR_PATH $_deployable_dir
-  docker push $GCR_PATH
-}
-
 deploy() {
-  build_node_container
+  build_container
   gcloud config set run/platform managed
   gcloud config set run/region us-west1
   gcloud run deploy  \

packages/google-cloud-logging/tests/environment/envctl/env_scripts/nodejs/compute.sh

@@ -47,26 +47,8 @@ verify() {
   set -e
 }
 
-
-build_node_container() {
-  export GCR_PATH=gcr.io/$PROJECT_ID/logging:$SERVICE_NAME
-  # copy super-repo into deployable dir
-  _env_tests_relative_path=${REPO_ROOT#"$SUPERREPO_ROOT/"}
-  _deployable_dir=$REPO_ROOT/deployable/$LANGUAGE
-
-  # copy over local copy of library
-  pushd $SUPERREPO_ROOT
-      tar -cvf $_deployable_dir/lib.tar --exclude node_modules --exclude env-tests-logging --exclude test --exclude system-test --exclude .nox --exclude samples --exclude docs .
-  popd
-  mkdir -p $_deployable_dir/$LIBRARY_NAME
-  tar -xvf $_deployable_dir/lib.tar --directory $_deployable_dir/$LIBRARY_NAME
-  # build container
-  docker build -t $GCR_PATH $_deployable_dir
-  docker push $GCR_PATH
-}
-
 deploy() {
-  build_node_container
+  build_container
   gcloud config set compute/zone $ZONE
   gcloud compute instances create-with-container \
     $SERVICE_NAME \

packages/google-cloud-logging/tests/environment/envctl/env_scripts/nodejs/kubernetes.sh

@@ -65,26 +65,9 @@ attach_or_create_gke_cluster(){
   set -e
 }
 
-build_node_container(){
-  export GCR_PATH=gcr.io/$PROJECT_ID/logging:$SERVICE_NAME
-  # copy super-repo into deployable dir
-  _env_tests_relative_path=${REPO_ROOT#"$SUPERREPO_ROOT/"}
-  _deployable_dir=$REPO_ROOT/deployable/$LANGUAGE
-
-  # copy over local copy of library
-  pushd $SUPERREPO_ROOT
-      tar -cvf $_deployable_dir/lib.tar --exclude node_modules --exclude env-tests-logging --exclude test --exclude system-test --exclude .nox --exclude samples --exclude docs .
-  popd
-  mkdir -p $_deployable_dir/$LIBRARY_NAME
-  tar -xvf $_deployable_dir/lib.tar --directory $_deployable_dir/$LIBRARY_NAME
-  # build container
-  docker build -t $GCR_PATH $_deployable_dir
-  docker push $GCR_PATH
-}
-
 deploy() {
   attach_or_create_gke_cluster
-  build_node_container
+  build_container
   cat <<EOF > $TMP_DIR/gke.yaml
     apiVersion: apps/v1
     kind: Deployment

packages/google-cloud-logging/tests/environment/envctl/envctl

@@ -46,6 +46,7 @@ build_container() {
     tar -cvf $_deployable_dir/lib.tar \
       --exclude tests --exclude .nox --exclude samples --exclude docs --exclude __pycache__ \
       --exclude target --exclude env-tests-logging --exclude test --exclude .git --exclude .github \
+      --exclude node_modules --exclude system-test \
       --exclude system-test --exclude environment-tests --exclude .kokoro .
   popd
   mkdir -p $_deployable_dir/_library

tests/environment

@@ -1 +1 @@
-Subproject commit 3b5b391d6afc746c59cdd3100ccc5e8d60793489
+Subproject commit f30dafa8b62bf197e39edd5aca57ce1cc62e9540