fix: use path.join and __dirname for require package.json#1936
fix: use path.join and __dirname for require package.json#1936shaffeeullah merged 1 commit intogoogleapis:mainfrom
Conversation
|
@ddelgrosso1 @shaffeeullah This is unnecessary. Additionally, I don't think it has anything to do with #1934, which it's supposed to close. The issue there is that the import is conditional (through a |
|
@timdp You are right because it didn't fix the problem, now it immediately fails in runtime. |
|
It would do, yes. In the case of esbuild, I imagine it leaves the Like I said on the original report, I would attempt to avoid the fallthrough altogether by making sure the source file is always at the same depth, whether or not it's gone through a build step. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1934 🦕