Skip to content

feat(deps)!: update octokit to v20#2490

Merged
chingor13 merged 2 commits intomainfrom
update-octokit
Mar 11, 2025
Merged

feat(deps)!: update octokit to v20#2490
chingor13 merged 2 commits intomainfrom
update-octokit

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Feb 27, 2025

This allows us to synchronize our octokit/rest versions across our libraries/bots

BEGIN_COMMIT_OVERRIDE
feat(deps)!: update octokit to v20 (#2490)
deps: update git-file-utils to v3 (octokit v20)
deps: update code-suggester to v5 (octokit v20)
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @chingor13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the octokit dependencies to version 20. It includes updates to @google-automations/git-file-utils, @octokit/graphql, @octokit/request, @octokit/request-error, @octokit/rest, and code-suggester. It also adds node-fetch as a dev dependency and removes some obsolete dependencies like encoding, is-plain-object, tr46, and whatwg-url. The minimum node version is bumped to 18.

Highlights

  • Dependency Updates: The core focus is upgrading octokit and related dependencies to their latest versions, ensuring compatibility and potentially incorporating new features or security patches.
  • Node Version Bump: The minimum supported Node.js version is increased to 18, aligning with the updated dependencies and modernizing the development environment.
  • Test Updates: The test suite is updated to include node-fetch and ensure compatibility with the new octokit version.

Changelog

Click here to see the changelog
  • package-lock.json
    • Updated @google-automations/git-file-utils from 2.0.0 to 3.0.0.
    • Updated @octokit/graphql from 5.0.0 to 7.1.0.
    • Updated @octokit/request from 6.0.0 to 8.3.1.
    • Updated @octokit/request-error from 3.0.0 to 5.1.0.
    • Updated @octokit/rest from 19.0.0 to 20.1.1.
    • Updated code-suggester from 4.2.0 to 5.0.0.
    • Added node-fetch as a dev dependency.
    • Removed encoding, is-plain-object, tr46, and whatwg-url.
    • Updated @octokit/auth-token from 3.0.2 to 4.0.0
    • Updated @octokit/core from 4.2.4 to 5.2.0
    • Updated @octokit/endpoint from 7.0.3 to 9.0.6
    • Updated @octokit/plugin-paginate-rest from 6.1.2 to 11.4.4-cjs.2
    • Updated @octokit/plugin-request-log from 1.0.4 to 4.0.1
    • Updated @octokit/plugin-rest-endpoint-methods from 7.2.3 to 13.3.2-cjs.1
  • package.json
    • Updated @google-automations/git-file-utils from 2.0.0 to 3.0.0.
    • Updated @octokit/graphql from 5.0.0 to 7.1.0.
    • Updated @octokit/request from 6.0.0 to 8.3.1.
    • Updated @octokit/request-error from 3.0.0 to 5.1.0.
    • Updated @octokit/rest from 19.0.0 to 20.1.1.
    • Updated code-suggester from 4.2.0 to 5.0.0.
    • Added node-fetch as a dev dependency.
  • src/github.ts
    • Added fetch option to GitHubCreateOptions interface.
    • Passed fetch option to octokit and graphql defaults.
  • test/changelog-notes/github-changelog-notes.ts
    • Imported node-fetch.
    • Passed fetch option to GitHub constructor.
  • test/github.ts
    • Imported node-fetch.
    • Passed fetch option to GitHub constructor and create method.
  • test/manifest.ts
    • Imported node-fetch.
    • Passed fetch option to GitHub constructor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

The name 'Octokit' is a play on GitHub's mascot, Octocat, a cat with octopus tentacles.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the octokit dependencies to v20 and makes necessary adjustments in the codebase. The changes include updating versions of various octokit packages and other dependencies like @google-automations/git-file-utils and code-suggester. Additionally, node-fetch is added as a dev dependency, and the minimum Node.js version is bumped to 18. The inclusion of fetch in the GitHub options is a good step towards flexibility.

Summary of Findings

  • Node.js Engine Version: The engines field in package.json and package-lock.json is updated to reflect the new minimum Node.js version (>=18.0.0). Ensure that all environments where this package is used meet this requirement.
  • Dependency Updates: Several dependencies, including @octokit/* packages, @google-automations/git-file-utils, and code-suggester, have been updated. Verify that these updates do not introduce any breaking changes or compatibility issues.
  • node-fetch as a dev dependency: node-fetch is added as a dev dependency. Confirm that this is the intended usage and that it's only used for development/testing purposes.
  • GitHub Options fetch: The fetch option is added to the GitHubCreateOptions interface and used in the GitHub class. Ensure that this option is correctly handled and provides the expected functionality.

Assessment

The pull request updates the octokit dependencies to v20 and makes necessary adjustments in the codebase. The changes seem reasonable, but it's important to verify that the dependency updates do not introduce any breaking changes or compatibility issues. The addition of node-fetch as a dev dependency and the fetch option in the GitHub options are good steps towards flexibility. I would recommend addressing the comments before requesting a review from someone else, but feel free to request another review from Gemini via /gemini review when you have addressed these comments and I'll take another look! Remember that in any circumstance, users should have others review and approve this code before merging.

feat(deps)!: update octokit to v20
@chingor13 chingor13 changed the title feat(deps)!: update octokit to v20" feat(deps)!: update octokit to v20 Feb 27, 2025
@chingor13 chingor13 marked this pull request as ready for review February 27, 2025 00:50
@chingor13 chingor13 requested review from a team as code owners February 27, 2025 00:50
@chingor13 chingor13 requested a review from ldetmer February 27, 2025 00:50
@chingor13 chingor13 added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 9f3b669 Mar 11, 2025
15 checks passed
@chingor13 chingor13 deleted the update-octokit branch March 11, 2025 16:19
@chingor13 chingor13 added the release-please:force-run To run release-please label Mar 11, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 11, 2025
@chingor13 chingor13 added the release-please:force-run To run release-please label Mar 11, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 11, 2025
soulsam480 pushed a commit to revenuehero/release-please that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants