chore(python): remove configure_previous_major_version_branches (#2137)

chore(python): remove configure_previous_major_version_branches from python post processor

Author: parthea

synthtool/languages/python.py

@@ -12,7 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import re
 import sys
 
 import json
@@ -129,64 +128,6 @@ def py_samples(
         s.copy([result], excludes=excludes)
 
 
-def configure_previous_major_version_branches() -> None:
-    """Configure releases from previous major version branches by editing
-    `.github/release-please.yml`.
-
-    The current library version is obtained from `version.py` in `google/**/version.py`,
-    or the `setup.py`.
-
-    Releases are configured for all previous major versions. For example,
-    if the library version is currently 3.5.1, the release-please config
-    will include v2, v1, and v0.
-    """
-
-    # In version.py:    __version__ = "1.5.2"
-    # In setup.py:      version = "1.5.2"
-    VERSION_REGEX = (
-        r"(?:__)?version(?:__)?\s*=\s*[\"'](?P<major_version>\d)\.[\d\.]+[\"']"
-    )
-    version_paths = list(Path(".").glob("google/**/version.py")) + [Path("setup.py")]
-
-    major_version = None
-
-    for p in version_paths:
-        match = re.search(VERSION_REGEX, Path(p).read_text())
-
-        if match is not None:
-            major_version = int(match.group("major_version"))
-            break
-
-    if major_version is None:
-        raise RuntimeError(
-            "Unable to find library version in files {} with regex {}".format(
-                version_paths, VERSION_REGEX
-            )
-        )
-
-    with open(".github/release-please.yml") as f:
-        release_please_yml = yaml.load(f, Loader=yaml.SafeLoader)
-
-    if major_version > 0 and "branches" not in release_please_yml:
-        branches = []
-        for version in range(major_version - 1, -1, -1):
-            branches.append(
-                {
-                    "branch": f"v{version}",
-                    "handleGHRelease": True,
-                    "releaseType": "python",
-                }
-            )
-
-        with open(".github/release-please.yml", "a") as f:
-            # comments can't be expressed in PyYAML
-            f.write(
-                """# NOTE: this section is generated by synthtool.languages.python
-# See https://github.com/googleapis/synthtool/blob/master/synthtool/languages/python.py\n"""
-            )
-            f.write(yaml.dump({"branches": branches}))
-
-
 def owlbot_main() -> None:
     """Copies files from staging and template directories into current working dir.
 
@@ -241,8 +182,6 @@ def owlbot_main() -> None:
         for noxfile in Path(".").glob("**/noxfile.py"):
             s.shell.run(["nox", "-s", "format"], cwd=noxfile.parent, hide_output=False)
 
-    configure_previous_major_version_branches()
-
 
 if __name__ == "__main__":
     owlbot_main()

tests/test_python_library.py

@@ -13,15 +13,13 @@
 # limitations under the License.
 
 import os
-import shutil
 from pathlib import Path
 import yaml
 
 import pytest
 
 from synthtool import gcp
 from synthtool.sources import templates
-from synthtool.languages import python
 from . import util
 
 
@@ -140,38 +138,3 @@ def test_split_system_tests():
         with open(templated_files / ".kokoro/presubmit/system-3.8.cfg", "r") as f:
             contents = f.read()
             assert "system-3.8" in contents
-
-
-@pytest.mark.parametrize(
-    "fixtures_dir",
-    [
-        Path(__file__).parent / "fixtures/python_library",  # just setup.py
-        Path(__file__).parent
-        / "fixtures/python_library_w_version_py",  # has google/cloud/texttospeech/version.py
-    ],
-)
-def test_configure_previous_major_version_branches(fixtures_dir):
-    with util.copied_fixtures_dir(fixtures_dir):
-        t = templates.Templates(PYTHON_LIBRARY)
-        result = t.render(".github/release-please.yml")
-        os.makedirs(".github")
-        shutil.copy(result, Path(".github/release-please.yml"))
-
-        python.configure_previous_major_version_branches()
-        release_please_yml = Path(".github/release-please.yml").read_text()
-
-        assert (
-            release_please_yml
-            == """releaseType: python
-handleGHRelease: true
-# NOTE: this section is generated by synthtool.languages.python
-# See https://github.com/googleapis/synthtool/blob/master/synthtool/languages/python.py
-branches:
-- branch: v1
-  handleGHRelease: true
-  releaseType: python
-- branch: v0
-  handleGHRelease: true
-  releaseType: python
-"""
-        )